Last modified: 2014-03-11 02:04:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56588, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54588 - VisualEditor: this.referenceSurface should be a Surface, not a SurfaceWidget
VisualEditor: this.referenceSurface should be a Surface, not a SurfaceWidget
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-25 02:50 UTC by Roan Kattouw
Modified: 2014-03-11 02:04 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-09-25 02:50:42 UTC 
In ve.ui.MWReferenceDialog, this.referenceSurface changed from being a Surface to a SurfaceWidget. I noticed this because I rebased some old code that used this.referenceSurface.getModel() and broke, but this seems to have happened a while ago with the introduction of SurfaceWidget.

When a variable name is 'fooSurface', it should be a Surface, not something else. In particular, you shouldn't have to do this.referenceSurface.getSurface() to get the surface.

The same applies to this.captionSurface in ve.ui.MWMediaEditDialog.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links