Last modified: 2014-10-27 10:39:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56590, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54590 - page-object Ruby gem deprecation warnings in VisualEditor browser tests
page-object Ruby gem deprecation warnings in VisualEditor browser tests
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
wmf-deployment
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
gci2013 https://www.mediawiki.org/wik...
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-25 04:50 UTC by spage
Modified: 2014-10-27 10:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-09-25 04:50:46 UTC
this is like bug 46893.

 $ cd extensions/VisualEditor/modules/ve-mw/test/browser
 $ bundle exec cucumber features/visual_editor_bullets.feature

If the tests progress, eventually they print out a lot of

*** DEPRECATION WARNING
*** You are calling a method named class_name at /home/spage/projects/core/extensions/VisualEditor/modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb:81:in `block in <top (required)>'.
*** This method does not exist in page-object so it is being passed to the driver.
*** This feature will be removed in the near future.
*** Please change your code to call the correct page-object method.
*** If you are using functionality that does not exist in page-object please request it be added.

*** DEPRECATION WARNING
*** You are calling a method named select_text at /home/spage/projects/core/extensions/VisualEditor/modules/ve-mw/test/browser/features/step_definitions/visual_editor_bullets_steps.rb:14:in `block in <top (required)>'.
*** [same last 4 lines]

The lines deprecated by the former are all of the form
  SOME_element.class_name.{should, should_not} match /disabled/
where the HTML has CSS class="ve-ui-widget ve-ui-tool ve-ui-tool-outdent ve-ui-widget-disabled".  I don't know the page-object equivalent to retrieving the CSS class (attribute( 'class' ), but maybe instead the code could use page-object's disabled? and enabled? methods.

The latter deprecation is odd since the test specifically requires "watir-webdriver/extensions/select_text"
Comment 3 Željko Filipin 2013-10-25 14:40:15 UTC
See also bug 46893
Comment 4 Chris McMahon 2013-10-25 17:17:12 UTC
Cheezy actually fixed this but hasn't updated the page-object gem yet https://github.com/cheezy/page-object/issues/192
Comment 5 Željko Filipin 2013-12-02 17:08:21 UTC
If you need more information (and you probably do), feel free to ask questions
here, at #wikimedia-qa freenode IRC channel or at QA mailing list:

https://lists.wikimedia.org/mailman/listinfo/qa
Comment 6 Andre Klapper 2014-10-26 17:43:50 UTC
(In reply to Chris McMahon from comment #4)
> Cheezy actually fixed this but hasn't updated the page-object gem yet
> https://github.com/cheezy/page-object/issues/192

Željko / Chris: Is this still a valid ticket one year after? Has Cheezy updated it in the meantime or is this still a task suitable for new contributors?
Comment 7 Željko Filipin 2014-10-27 10:39:48 UTC
After a quick look at VisualEditor Jenkins jobs[0], looks like this is fixed. Please reopen if you see the problem again.

0: https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links