Last modified: 2013-10-21 22:01:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56650, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54650 - GeoIP updates can users to jump to new country in geowiki files
GeoIP updates can users to jump to new country in geowiki files
Status: NEW
Product: Analytics
Classification: Unclassified
Visualization (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-26 16:11 UTC by christian
Modified: 2013-10-21 22:01 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description christian 2013-09-26 16:11:34 UTC
Editors get geocoded again and again for each day they are
considered active.

So if the GeoIP gets updated, active editors with jump to a
different country from one day to the next.

So consider I edit 5 pages on enwiki on 2013-08-10 using an IP
address that's associated to Italy at that point in time.
On 2013-08-29 the IP->Country database gets updated, and that
previous IP is now marked as United States.
The scripts would count me active for United States from that day
on.

+------------+---------+---------------+
|    Date    | Austria | United States |
+------------+---------+---------------+
| 2013-08-11 |    *    |               |
| 2013-08-12 |    *    |               |
|    ...     |    *    |               |
| 2013-08-28 |    *    |               |
| 2013-08-29 |         |       *       |
| 2013-08-30 |         |       *       |
|    ...     |         |       *       |
| 2013-09-10 |         |       *       |
+------------+---------+---------------+
Comment 1 christian 2013-09-26 16:12:15 UTC
Mhmm. That table should have been

+------------+---------+---------------+
|    Date    |  Italy  | United States |
+------------+---------+---------------+
| 2013-08-11 |    *    |               |
| 2013-08-12 |    *    |               |
|    ...     |    *    |               |
| 2013-08-28 |    *    |               |
| 2013-08-29 |         |       *       |
| 2013-08-30 |         |       *       |
|    ...     |         |       *       |
| 2013-09-10 |         |       *       |
+------------+---------+---------------+
Comment 2 Brion Vibber 2013-09-26 16:14:50 UTC
That behavior sounds sane enough to me. Do you recommend something alternative?
Comment 3 christian 2013-09-26 16:36:36 UTC
(In reply to comment #2)
> That behavior sounds sane enough to me. Do you recommend something
> alternative?

I'd expect a table like:
+------------+---------+---------------+
|    Date    |  Italy  | United States |
+------------+---------+---------------+
| 2013-08-11 |    *    |               |
| 2013-08-12 |    *    |               |
|    ...     |    *    |               |
| 2013-08-28 |    *    |               |
| 2013-08-29 |    *    |               |
| 2013-08-30 |    *    |               |
|    ...     |    *    |               |
| 2013-09-10 |    *    |               |
+------------+---------+---------------+


If the 5 edits came from an Italian IP address when they were made, those 5
edits should count for Italy for the whole 30-day period, regardless where the
IP "wanders" afterwards.

Of course, I make 5 additional edits from the very same address on 2013-09-05
(that's after the Italy->US switch), the table should become:
+------------+---------+---------------+
|    Date    |  Italy  | United States |
+------------+---------+---------------+
| 2013-08-11 |    *    |               |
| 2013-08-12 |    *    |               |
|    ...     |    *    |               |
| 2013-08-28 |    *    |               |
| 2013-08-29 |    *    |               |
| 2013-08-30 |    *    |               |
|    ...     |    *    |               |
| 2013-09-04 |    *    |               |
| 2013-09-05 |    *    |       *       |
| 2013-09-06 |    *    |       *       |
|    ...     |    *    |       *       |
| 2013-09-10 |    *    |       *       |
+------------+---------+---------------+

On 2013-09-10, I'd be considered active editor in Italy due to the first 5
editors, when the IP was associated to Italy. And additionally, I am considered
active editor for the United States due to the latter edits.

(That would match the behaviour we're seeing if I do the first 5 edits on an IP that's always Italy, and the second 5 edits on an IP that's always United States)
Comment 4 Diederik van Liere 2013-10-21 22:01:50 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/analytics/cards/1221

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links