Last modified: 2013-10-24 00:24:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56716, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54716 - Button on MWOAuthManageMyGrants/manage should be text instead
Button on MWOAuthManageMyGrants/manage should be text instead
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Dan Garry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-27 17:52 UTC by Dan Garry
Modified: 2013-10-24 00:24 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of [[mw:Special:MWOAuthManageMyGrants/manage/34]] (113.31 KB, image/png)
2013-10-10 01:46 UTC, MZMcBride
Details

Description Dan Garry 2013-09-27 17:52:31 UTC
Feedback from the designers on OAuth interface.

When managing grants for one particular consumer ([[Special:MWOAuthManageMyGrants/manage/N]] for some N) "deauthorise" should be text above the "Update grants" button, rather than a separate button, as it's not intended to be the main functionality of the screen.
Comment 1 Brad Jorsch 2013-09-27 17:58:39 UTC
The one concern I have about this is whether users will miss the text and be asking "How do I remove permission for something to use my account?"
Comment 2 Dan Garry 2013-09-27 18:19:22 UTC
I hear you. Let's look at alternative ways to make it less prominent while still letting the "Update grants" button be the more prominent one. Any suggestions?
Comment 3 Brad Jorsch 2013-09-27 18:29:35 UTC
I think I've heard the UI people say before that they like to color the "primary" button blue or something like that. Could that do it?
Comment 4 Dan Garry 2013-09-27 18:37:25 UTC
That was already done in the screenshot that Jared reviewed. He was still a bit unhappy with the big red button. Are there other alternatives?
Comment 5 Chris Steipp 2013-09-30 21:52:39 UTC
I'm not entirely sure there is.

Deauthorize, I would argue, *is* one of the 2 main reasons anyone visits that page. For example, facebook offers deauthorize ("Remove") with 1 click, while changing the permissions requires at least 2.
Comment 6 MZMcBride 2013-10-10 01:45:48 UTC
I'm looking at <https://www.mediawiki.org/wiki/Special:MWOAuthManageMyGrants/manage/34> and the two grey buttons side by side aren't great. I'll upload a screenshot in a moment.
Comment 7 MZMcBride 2013-10-10 01:46:43 UTC
Created attachment 13467 [details]
Screenshot of [[mw:Special:MWOAuthManageMyGrants/manage/34]]
Comment 8 Dan Garry 2013-10-10 09:26:04 UTC
(In reply to comment #6)
> I'm looking at
> <https://www.mediawiki.org/wiki/Special:MWOAuthManageMyGrants/manage/34> and
> the two grey buttons side by side aren't great. I'll upload a screenshot in a
> moment.

Thanks for pointing that out. This appears to be a problem with MonoBook more than OAuth; all the coloured buttons in OAuth are grey, but this is also true of other coloured buttons (such as in CreateAccount) as well.
Comment 9 Dan Garry 2013-10-10 10:20:43 UTC
(In reply to comment #5)
> I'm not entirely sure there is.
> 
> Deauthorize, I would argue, *is* one of the 2 main reasons anyone visits that
> page. For example, facebook offers deauthorize ("Remove") with 1 click, while
> changing the permissions requires at least 2.

I just checked to see how Facebook handles this and they have a deauthorise button on the app listing, and then also an edit dialogue separate from it (which still has a deauthorise button on it). In contrast, we're doing it together.

I suppose the other alternative is that we pull them apart too. We could text for both deauthorising and editing on the main MWOAuthManageMyGrants, and text for deauthorising on the edit bit for each app.

CCing the platform designers, May and Kaity, for input.
Comment 10 Aaron Schulz 2013-10-24 00:24:34 UTC
The forms are split, so this is moot.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links