Last modified: 2013-09-30 16:19:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56727, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54727 - VisualEditor: Can't remove categories from 'Page Settings' modal in latest build
VisualEditor: Can't remove categories from 'Page Settings' modal in latest build
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-10-03
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-27 23:36 UTC by Trevor (Wikia)
Modified: 2013-09-30 16:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Trevor (Wikia) 2013-09-27 23:36:17 UTC
Currently on MediaWiki.org, categories cannot be removed from the 'Page Settings' modal. This is true of new categories added and existing categories.

https://www.mediawiki.org/wiki/VisualEditor:Test1234567?veaction=edit

Inez says he's working on a fix now.
Comment 1 Trevor (Wikia) 2013-09-27 23:39:03 UTC
Also just checked editing a sort key — that functionality is no longer working as well. You can enter text into the field and close the inspector, but when it is reopened the text is not retained.
Comment 2 Gerrit Notification Bot 2013-09-28 00:08:43 UTC
Change 86341 had a related patch set uploaded by Inez:
(bug 54727) item itself is an item, there is no need to try to pass item of that item

https://gerrit.wikimedia.org/r/86341
Comment 3 Inez Korczyński 2013-09-28 00:17:28 UTC
Bugfix for removal is waiting for review. Sortkey still not fixed - Trevor: Can you split it into separated bug?
Comment 4 Gerrit Notification Bot 2013-09-29 17:09:10 UTC
Change 86341 had a related patch set uploaded by Catrope:
(bug 54727) item itself is an item, there is no need to try to pass item of that item

https://gerrit.wikimedia.org/r/86341
Comment 5 Gerrit Notification Bot 2013-09-29 17:11:07 UTC
Change 86341 merged by jenkins-bot:
removedItems[i] is already an item, no need to pass removedItems[i].item

https://gerrit.wikimedia.org/r/86341
Comment 6 James Forrester 2013-09-29 19:07:29 UTC
Marking as "FIXED"; have removed "or change sort key" from title per discussion with Inez.
Comment 7 Gerrit Notification Bot 2013-09-30 15:52:39 UTC
Change 86673 had a related patch set uploaded by Jforrester:
removedItems[i] is already an item, no need to pass removedItems[i].item

https://gerrit.wikimedia.org/r/86673
Comment 8 Gerrit Notification Bot 2013-09-30 15:52:59 UTC
Change 86674 had a related patch set uploaded by Jforrester:
removedItems[i] is already an item, no need to pass removedItems[i].item

https://gerrit.wikimedia.org/r/86674
Comment 9 Gerrit Notification Bot 2013-09-30 16:05:30 UTC
Change 86673 merged by jenkins-bot:
removedItems[i] is already an item, no need to pass removedItems[i].item

https://gerrit.wikimedia.org/r/86673
Comment 10 Gerrit Notification Bot 2013-09-30 16:06:27 UTC
Change 86674 merged by jenkins-bot:
removedItems[i] is already an item, no need to pass removedItems[i].item

https://gerrit.wikimedia.org/r/86674

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links