Last modified: 2014-03-20 11:21:08 UTC
low priority issue. If you just visit thumb.php (plain thumb.php, not thumb_handler.php), with no f parameter specified, it should probably output a list of all possible parameters it takes.
I would like to work on this bug. Would someone assign this to me?
Prepare the patch http://www.mediawiki.org/wiki/Gerrit/Tutorial
I have tried to fix it, would you take a look at it Proposed Patch: http://fpaste.org/85648/94892293/ (the additions are between line 111 to line 118) Please let me know, if i have understood it correctly and if the patch i working as it should. If not, what do i have to do to fix it. Thanks.
(In reply to Rahul Mishra from comment #3) > I have tried to fix it, would you take a look at it Thanks for your fix. But, your patch doesn't seem to be in a diff/patch format. When referring to a patch, its always helpful if you can make it in the std. diff format. You can check here, how to create a diff/patch using git diff command (http://git-scm.com/docs/git-diff). Try to prepare a gerrit patch set so that its easy for other devs to test your code, and debug. http://www.mediawiki.org/wiki/Gerrit/Tutorial
Change 118822 had a related patch set uploaded by Santosh2201: thumb.php should output docs if no file specified https://gerrit.wikimedia.org/r/118822
Created attachment 14846 [details] thumb.php should output docs if no file specified.
(In reply to Rahul Mishra from comment #6) > Created attachment 14846 [details] Great!This one really looks like a patch. Why dont you push the same into gerrit? I have added the how-to in Comment#4
(In reply to Tony Thomas from comment #7) > > Created attachment 14846 [details] > I have added the how-to in Comment#4 Thanks, for your comment, i was having some problem with my gerrit account, will ask on #mediawiki and fix it as fast as possible.
Change 119350 had a related patch set uploaded by Nemo bis: Show an error message when no or invalid parameters are passed to thumb.php https://gerrit.wikimedia.org/r/119350
