Last modified: 2014-10-04 01:13:19 UTC
With the upgrade to OTRS v. 3 the former "1-click spam" patch was no longer functional. This was an extremely useful tool for our agents and we have had numerous requests for it to be re-enabled. The former obsolete patch/code is available at <http://svn.wikimedia.org/svnroot/mediawiki/trunk/otrs/patches/50-one-click-spam.patch> if that is of help. I am unsure of the reasons the code was no longer compatible post upgrade.
Created attachment 13856 [details] one click spam button JavaScript that adds a button which says "SPAM", and implements the one-click-spam functionality in QueueView. Note that it looks a bit weird in Firefox (top is cut off), but fine in Chromium using OSX 10.9.
I guess that it needs to be added to the operations/software/otrs repo.
Created attachment 13876 [details] v2 New patch sends the request asynchronously and hides the ticket after success rather than reloading the page. Also it loads better.
I have tested the proposed patch and found no issues. It works great. For reference, my UA is as follows: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0 I would support enabling this as soon as possible, of course pending further confirmation/testing and review.
Andre: who should be assigned to this bug report?
(In reply to comment #5) > Andre: who should be assigned to this bug report? Jeff Green is already CC'ed (who sometimes helps out with OTRS patches); Philippe would be the PM here, kind of.
Sure, you can add me as the PM, but I don't think I can actually do much here. As I understand it, we're looking for someone who can add the patch - that's not me. And I have no control over the engineering resources. :)
(In reply to Kunal Mehta (Legoktm) from comment #3) > Created attachment 13876 [details] > New patch sends the request asynchronously and hides the ticket after > success rather than reloading the page. legoktm: Could you put that patch into Gerrit against http://git.wikimedia.org/blob/operations%2Fsoftware%2Fotrs.git/HEAD/patches%2F50-one-click-spam.patch ?
(In reply to Andre Klapper from comment #8) > legoktm: Could you put that patch into Gerrit against > http://git.wikimedia.org/blob/operations%2Fsoftware%2Fotrs.git/HEAD/ > patches%2F50-one-click-spam.patch ? Well, it's not really a patch to the software, so I'm not sure that makes sense.
FWIW, in OTRS I usually use bulk actions after mass-checking the spam mails with an extension like https://addons.mozilla.org/firefox/addon/checkfox/ (Probably obvious to many but not to all and I don't know where else to post it. Originally suggested to me by Frieda many years ago.)
This JavaScript 'fix' is basically the equivalent of fixing a MediaWiki core bug with a default-on gadget. It's not a patch for the software itself. It could also be a lot simpler than it currently is.
(In reply to Alex Monk from comment #11) > This JavaScript 'fix' is basically the equivalent of fixing a MediaWiki core > bug with a default-on gadget. It's not a patch for the software itself. It > could also be a lot simpler than it currently is. First, I don't know JS that well, and put this together by just messing with my browser console. Please improve it :D Second, I agree with your analogy. But in this case, I'm not sure this is totally a bad thing. I think we should evaluate it based on: a) How important is this feature for OTRS agents (<https://otrs-wiki.wikimedia.org/wiki/Talk:Upgrade_issues#Can.27t_get_rid_of_spam_as_quickly>). b) How likely we're going to be able to get someone (who??) to write this properly as an OTRS extension (if those exist??). RD or another OTRS admin can probably answer a), I don't know who would be able to answer b). Occasionally, we do hotfix hacks in site-wide JS/CSS which really should be done server-side, but the caveat is that those are promptly fixed in a proper manner. If we do deploy this JS script, it's even more unlikely it would ever get a proper fix. But being realistic, I doubt anyone is ever going to fix this properly to begin with.
Created attachment 16667 [details] OTRS 1 click spam button JS gadget
