Last modified: 2014-04-18 11:24:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56764, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54764 - make all pyflakes jobs voting per default
make all pyflakes jobs voting per default
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-29 11:52 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-04-18 11:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-09-29 11:52:34 UTC
The pyflakes jobs are non voting per default. We would want to make them voting to avoid having to add exception in Zuul configuration.

To be able to achieve that, we need to look at each of the repositories having pyflakes jobs, make sure they pass and then adjust Zuul configuration to remove the voting: true exceptions.
Comment 1 Antoine "hashar" Musso (WMF) 2013-10-01 08:47:58 UTC
Merlijn van Deen has spot a mistake in the way pyflakes was being called.  It was missing a path argument:

 - pyflakes
 + pyflakes .

https://gerrit.wikimedia.org/r/#/c/86727/


That causes some pyflakes jobs to be failing again :-]
Comment 2 Gerrit Notification Bot 2014-04-18 11:21:19 UTC
Change 127229 had a related patch set uploaded by Hashar:
Make pep8 jobs voting by default

https://gerrit.wikimedia.org/r/127229
Comment 3 Gerrit Notification Bot 2014-04-18 11:23:25 UTC
Change 127229 merged by jenkins-bot:
Make pyflakes jobs voting by default

https://gerrit.wikimedia.org/r/127229
Comment 4 Antoine "hashar" Musso (WMF) 2014-04-18 11:24:08 UTC
The pyflakes jobs are now voting by default.

Four jobs have been made voting in the process:

    integration-jenkins-pyflakes
    labs-nagios-builder-pyflakes
    mw-tools-codeutils-pyflakes
    pywikibot-i18n-pyflakes

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links