Last modified: 2013-10-13 19:09:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56771, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54771 - SubPageList not showing the subpages right for other pages?
SubPageList not showing the subpages right for other pages?
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
SubPageList (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-29 21:34 UTC by Jamie Thingelstad
Modified: 2013-10-13 19:09 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jamie Thingelstad 2013-09-29 21:34:53 UTC
Did a test of SubPageList on this page

http://wikiapiary.com/wiki/User:Thingles/Scratch1

and it isn't showing what I would expect. 

Then, on this page:

http://wikiapiary.com/wiki/User:Thingles

It does show the right things.
Comment 1 Jeroen De Dauw 2013-09-30 09:16:44 UTC
There is a serious bug with parser function argument handling in ParserHooks 1.1. Please upgrade to 1.2.
Comment 2 Andre Klapper 2013-09-30 09:48:14 UTC
Please update this ticke after upgrading.
Comment 3 Jamie Thingelstad 2013-09-30 11:22:39 UTC
Updated ParserHooks to 6f51ee6 and SubPageList to bb425b4 and now the test page shows those other pages:

http://wikiapiary.com/wiki/User:Thingles/Scratch1

However, the format parameter doesn't seem to be doing anything. You want a new bug for that or leave it on this?
Comment 4 Jeroen De Dauw 2013-09-30 14:18:39 UTC
huh - looks like I forgot to hook up this param... its implemented and working in the module itself. Shows the unit tests on their own do not suffice. Added an integration test now.
Comment 6 Jamie Thingelstad 2013-10-01 00:20:25 UTC
At this point I've hijacked the now resolved bug, but, I pulled ec7729ef1cb94c2a98dc4541fdca5e3ca8a89718 and the format still is always ul, regardless of what I specify. :-\

Test page: http://wikiapiary.com/wiki/User:Thingles/Scratch1
Comment 7 Jeroen De Dauw 2013-10-01 08:47:00 UTC
Works for me...

{{#splist:|intro=foo|format=ol}}

foo
    1. daah
        1. dddd 
    2. hax 

You pulled both ParserHooks and SubPageList right? The first issue in this bug was in the former, the second one in the later.
Comment 8 Jamie Thingelstad 2013-10-13 18:52:28 UTC
Just did a fresh pull of Ia3d3f71c426154f5799346e99e12cae185297526 and looks good:

http://wikiapiary.com/wiki/User:Thingles/Scratch1

I may have had bad wikitext or there were bad docs since I had "li" instead of "ol" as the format. I swear there was a "list" format in the doc that said it would do comma separated but I see there is no option for that in the usage page.

Looks good.

(I see the list option was removed from mw.o: https://www.mediawiki.org/w/index.php?title=Extension%3ASubPageList&diff=800478&oldid=792700)
Comment 9 Jeroen De Dauw 2013-10-13 18:59:37 UTC
There was such a format, though it has been removed. New docs are at

https://github.com/wikimedia/mediawiki-extensions-SubPageList/blob/master/doc/USAGE.md

Also documented in the rel notes

https://github.com/wikimedia/mediawiki-extensions-SubPageList/blob/master/doc/RELEASE-NOTES.md
Comment 10 Jamie Thingelstad 2013-10-13 19:09:50 UTC
One of the most professional feeling MW extensions I've seen. Nicely done Jeroen!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links