Last modified: 2013-10-08 19:38:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54779 - Webrequest, mobile, and zero request stream lacking mf-m=a and mf-m=b markers
Webrequest, mobile, and zero request stream lacking mf-m=a and mf-m=b markers
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 53806
  Show dependency treegraph
 
Reported: 2013-09-30 10:58 UTC by christian
Modified: 2013-10-08 19:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description christian 2013-09-30 10:58:18 UTC
The webrequest stream, mobile webrequest stream, and zero webrequest stream
used to come with "mf-m=a", and "mf-m=b" markers in the X-Analytics field.

Now they no longer come with those markers.

However, it seems we need them markers to track usage of the
mobilefrontend for alpha/beta site.
(Diederik might know the details)

As there were some changes around handling of the X-Analytics field, and
around how the zero markers get set there, those changes of the puppet
repo might be related:
  07b8b855b576eb2316bc69fdf87b542459f9791d
  cfdf66f9362f0d169e73f8640d81d1c6ffdfc43a
  1755cfe5d556f20acae6a9c3cb59e9b38e1327e3


The markers seem to be set in includes/MobileContext.php:907 of
git:mediawiki/extensions/MobileFrontend.

The latest packets with those markers are:
+--------------------+------------+---------------------+
| Stream             | sequence#  |     timestamp       |
+--------------------+------------+---------------------+
| sampled-1000       | 5601268853 | 2013-09-26T22:32:55 |
| mobile-sampled-100 | 4258131496 | 2013-09-26T22:44:17 |
| zero               | 4258572097 | 2013-09-26T22:56:20 |
+--------------------+------------+---------------------+
Comment 1 Diederik van Liere 2013-09-30 11:06:24 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/analytics/cards/1189
Comment 2 Faidon Liambotis 2013-09-30 18:03:36 UTC
This was broken by my change to Varnish to fix #53806 (I6ac2dd). I flagged this as a potential issue on the commit message, but Yuri assured me that MediaWiki never sets X-Analytics. He was obviously wrong and I was wrong to be lazy and not checking it myself :)

Fixing this isn't trivial as our cache is poisoned by the Varnish setting X-Analytics and it's impossible to know if the header that we have was set by MediaWiki or Varnish. Maybe we can hack it up and specifically regexp mf-m and append it.

Before we go down that path though, can we have a specification of what X-Analytics is/supposed to be, what key/values does it have and what part of our infrastructure is supposed to set each key? We're obviously having troubles communicating on a peer-to-peer basis, so let's fix this once and for all :)
Comment 3 Diederik van Liere 2013-09-30 22:43:21 UTC
A specification of X-Analytics can be found at https://wikitech.wikimedia.org/wiki/X-Analytics
Comment 4 Gerrit Notification Bot 2013-10-01 13:10:29 UTC
Change 86846 had a related patch set uploaded by Faidon Liambotis:
varnish mobile: don't override MW's X-Analytics

https://gerrit.wikimedia.org/r/86846
Comment 5 Gerrit Notification Bot 2013-10-01 13:20:17 UTC
Change 86846 merged by Faidon Liambotis:
varnish mobile: don't override MW's X-Analytics

https://gerrit.wikimedia.org/r/86846
Comment 6 christian 2013-10-05 18:28:22 UTC
mf-m tags came back and were within expectations for the last four days.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links