Last modified: 2013-10-01 09:31:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56816, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54816 - Attempting to use to API to review a revision that has already been approved gives "Success"
Attempting to use to API to review a revision that has already been approved ...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-01 05:21 UTC by This, that and the other (TTO)
Modified: 2013-10-01 09:31 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-10-01 05:21:37 UTC
Try to review a revision that has already been approved, e.g. on testwiki,

action=review&revid=180749

We see

{
    "review": {
        "result": "Success"
    }
}

but in reality, nothing was done. 

Perhaps some kind of error message is needed here.
Comment 1 Kunal Mehta (Legoktm) 2013-10-01 05:26:12 UTC
Technically nothing went wrong (the revision you wanted to review was reviewed), so an error wouldn't make sense here. I think adding a 'nochange': '' key would work, just like how action=edit works.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links