Last modified: 2014-07-15 16:41:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56819, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54819 - $wgDisableCounters is used for two independent functions (disabling site counters and displaying counters as they are)
$wgDisableCounters is used for two independent functions (disabling site coun...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.21.x
All All
: Normal minor (vote)
: ---
Assigned To: Rohan Rawat
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-01 06:33 UTC by Volodya
Modified: 2014-07-15 16:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Volodya 2013-10-01 06:33:02 UTC 
$wgDisableCounters is used for two independent functions (partially thanks to bug 17795). The first one is disabling site counters (which is what's expected), the second one is displaying counters as they are (which is not expected in some situations (see below)).

For example, if http://www.mediawiki.org/wiki/Extension:SysopDisableSiteCounters is installed it disables the counters *for the specific user*, and that means that this user all of the sudden cannot view the counter as well. This is *not* expected, and requires hacks to the MediaWiki software to re-enable the display again.

What we need is a second variable: <code>$wgEnableCounterDisplay=true;</code> (no need for double negatives) in DefaultSettings.php.
Comment 1 Gerrit Notification Bot 2014-06-12 14:36:04 UTC 
Change 139114 had a related patch set uploaded by Rohan013:
Fix for bug 54819, adds $wgEnableCounterDisplay variable in DefaultSettings.php

https://gerrit.wikimedia.org/r/139114
Comment 2 Gerrit Notification Bot 2014-07-15 16:41:37 UTC 
Change 139114 had a related patch set uploaded by Rohan013:
Add $wgEnableCounterDisplay variable in DefaultSettings.php

https://gerrit.wikimedia.org/r/139114
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links