Last modified: 2014-02-27 02:06:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56863, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54863 - VisualEditor: [Regression] Text formatting menu broken in Firefox
VisualEditor: [Regression] Text formatting menu broken in Firefox
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High major
: ---
Assigned To: Trevor Parscal
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-02 04:32 UTC by John Mark Vandenberg
Modified: 2014-02-27 02:06 UTC (History)
4 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2013-10-02 04:32:18 UTC
The Paragraph style tool in toolbar is not working in Firefox most of the time.

Steps to reproduce
1. https://www.mediawiki.org/wiki/special:random
2. Active VE (Click 'Edit')
3. Place cursor on normal text

Expected results:
The paragraph style selector should change to 'Paragraph'

Actual results (in Firefox 24/linux):
9 out of 10 times, nothing changes.  The tool does not work at all.  Changing style doesnt work.

This doesnt happen on enwp.

In debug=true mode, the paragraph selector nearly always changes to Paragraph, but sometimes it then doesnt change to Heading if the cursor is moved to a Heading and changing the style doesnt work.

There is nothing in the JS console to suggest what might be the problem.
Comment 1 Brion Vibber 2013-10-02 16:39:40 UTC
Confirmed in Firefox 24 on Mac OS X 10.8.5 -- I had it work once, then not work several times after reloading. Something funky!
Comment 2 Trevor Parscal 2013-10-02 18:24:13 UTC
I believe that this is a regression of sorts:

Behavior 1: 2 click, works

1. Click tool to open menu
2. Move mouse to item you want to select
3. Click to select item

Behavior 2: Click and drag, broken since recent refactor of toolbar

1. Press mouse button down on tool to open menu
2. Move mouse to item you want to select
3. Release mouse button to select item

I can confirm that Behavior 2 is broken.

Can you confirm that Behavior 1 works?

The only difference between browsers seems to be that on Chrome clicking and dragging doesn't highlight items as you drag over them, but in Firefox it does, which is probably why you were expecting the menu to select the item using click and drag on that browser.
Comment 3 John Mark Vandenberg 2013-10-02 23:40:47 UTC
(In reply to comment #2)
> I believe that this is a regression of sorts:
> 
> Behavior 1: 2 click, works
> 
> 1. Click tool to open menu
> 2. Move mouse to item you want to select
> 3. Click to select item
>..
> Can you confirm that Behavior 1 works?

yes, that works.
 
> The only difference between browsers seems to be that on Chrome clicking and
> dragging doesn't highlight items as you drag over them, but in Firefox it
> does,
> which is probably why you were expecting the menu to select the item using
> click and drag on that browser.

My steps to reproduce dont include any clicking, let alone dragging.  You can reproduce this bug using the only they keyboard.
Comment 4 Brion Vibber 2014-02-27 01:54:35 UTC
I'm no longer able to reproduce this in Firefox 27.0.1 or Firefox 30 nightly.
Comment 5 Brion Vibber 2014-02-27 02:04:40 UTC
Just for good measure, also tested extended-support release which is Firefox 24.3; seems ok there too. Either specific conditions need to trigger this which we aren't hitting, or it's gotten fixed...
Comment 6 James Forrester 2014-02-27 02:06:25 UTC
Can't reproduce either; that's four devs (on various environments) unable to reproduce today, so I'm going to claim that this is fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links