Last modified: 2013-10-06 06:24:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56878, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54878 - Proximity search doesn't highlight nor sometimes show matching text


Summary:	Proximity search doesn't highlight nor sometimes show matching text

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CirrusSearch (Other open bugs)
Version:	master
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	https://it.wiktionary.org/w/index.php...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-02 15:17 UTC by Nemo
Modified:	2013-10-06 06:24 UTC (History)
CC List:	3 users (show)

See Also:	54526
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2013-10-02 15:17:17 UTC

The search in the URL ("femminile di"~2) gives me this as top results:

----

flessa
Italiano Aggettivo, forma flessa flessa f sing    singolare 
3 KB (509 parole) - 17:01, 9 lug 2013

note
Italiano Aggettivo, forma flessa note f pl    singolare   plurale 
12 KB (1 793 parole) - 18:53, 7 lug 2013

italiana
Italiano Aggettivo, forma flessa italiana f sing    singolare 
7 KB (1 098 parole) - 03:30, 9 lug 2013

derivate
Italiano Aggettivo, forma flessa derivate f pl    singolare 
4 KB (634 parole) - 13:45, 9 lug 2013

quella
Italiano Aggettivo, forma flessa quella f sing femminile di quello
3 KB (499 parole) - 07:03, 8 lug 2013

----

All of them are correct pages, but the first 4 don't show the matching text in the snippet. Additionally, none of them is highlighted.

Reported at https://it.wiktionary.org/w/index.php?title=Wikizionario:Bar&diff=1543867&oldid=1543832

Comment 1 Nik Everett 2013-10-02 15:31:47 UTC

This is known already (Bug: 54526) but I'm going to usurp this bug to write a work around that works for queries like yours.

Comment 2 Gerrit Notification Bot 2013-10-02 18:00:46 UTC

Change 87177 had a related patch set uploaded by Manybubbles:
Tests for workaround of highlighting issue.

https://gerrit.wikimedia.org/r/87177

Comment 3 Gerrit Notification Bot 2013-10-02 18:07:30 UTC

Change 87179 had a related patch set uploaded by Manybubbles:
Highlight both plain and stemmed fields.

https://gerrit.wikimedia.org/r/87179

Comment 4 Gerrit Notification Bot 2013-10-02 18:08:23 UTC

Change 87177 merged by jenkins-bot:
Tests for workaround of highlighting issue.

https://gerrit.wikimedia.org/r/87177

Comment 5 Nik Everett 2013-10-02 18:09:43 UTC

So patch that I've pushed for this bug will highlight the result twice:
once with the strict matches that you get from a phrase match and one with the stemmed match you get without it.  It'll take the stemmed match if there is one, otherwise it'll give you the strict match.  The other bug (Bug 54526) is now officially for highlighting both matches all together.

Comment 6 Gerrit Notification Bot 2013-10-02 20:48:30 UTC

Change 87179 merged by jenkins-bot:
Highlight both plain and stemmed fields.

https://gerrit.wikimedia.org/r/87179

Comment 7 Nik Everett 2013-10-02 20:50:20 UTC

This has been merged.  It's an improvement but not a real fix.  See Bug 54526 for the real fix.

Comment 8 Nemo 2013-10-02 20:58:23 UTC

Thanks!

Comment 9 Nik Everett 2013-10-02 23:56:25 UTC

Verified on itwiktionary with the provided query.  That query, at least, has highlighting.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links