Last modified: 2013-10-09 05:51:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56891, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54891 - VisualEditor: Linktrail & linkprefix appear to be active on zhwiki when they shouldn't be
VisualEditor: Linktrail & linkprefix appear to be active on zhwiki when they ...
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
Language (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: James Forrester
:
Depends on:
Blocks: ve-nonenglish
  Show dependency treegraph
 
Reported: 2013-10-02 19:14 UTC by Liangent
Modified: 2013-10-09 05:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-10-02 19:14:12 UTC
Repro:

1. Create a new page with wikitext "[[中文]]" on zhwiki
2. VisualEditor-edit this page and type "s" at the end
3. The whole document now looks as if it has a link to "中文" with text "中文s"
4. Save the page
5. Resulting wikitext is "[[中文]]s", and in rendered HTML (both PHP and Parsoid - bug 41151), "s" is not a part of the link text
Comment 1 Liangent 2013-10-02 19:16:52 UTC
Linkprefix is also affected - type "s" at the beginning instead of the end in the repro above.
Comment 2 James Forrester 2013-10-02 22:37:19 UTC
(In reply to comment #0)
> Repro:
> 
> 1. Create a new page with wikitext "[[中文]]" on zhwiki
> 2. VisualEditor-edit this page and type "s" at the end
> 3. The whole document now looks as if it has a link to "中文" with text "中文s"
> 4. Save the page
> 5. Resulting wikitext is "[[中文]]s", and in rendered HTML (both PHP and
> Parsoid
> - bug 41151), "s" is not a part of the link text

I can't reproduce that - I got <a>中文</a>s in the edit surface, and it saved as expected:

* https://zh.wikipedia.org/w/index.php?title=User:Jdforrester_(WMF)/Sandbox&diff=28804968&oldid=28804967 (for linktrail)

https://zh.wikipedia.org/w/index.php?title=User:Jdforrester_(WMF)/Sandbox&diff=28804969&oldid=28804968 (for linkhead)

Are you absolutely sure it showed as <a>中文s</a> (because it really shouldn't!)? What browser were you using?
Comment 3 Liangent 2013-10-02 22:54:54 UTC
(In reply to comment #2)
> Are you absolutely sure it showed as <a>中文s</a> (because it really
> shouldn't!)?

Yes - already checked with inspector.

> What browser were you using?

Firefox 22.
Comment 4 James Forrester 2013-10-02 23:36:07 UTC
I get:

<p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>

… when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).

Very odd. :-(
Comment 5 Liangent 2013-10-02 23:40:00 UTC
(In reply to comment #4)
> I get:
> 
> <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> 
> … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> 
> Very odd. :-(

btw I can't reproduce it using Chrome either.
Comment 6 Liangent 2013-10-03 00:08:54 UTC
(In reply to comment #4)
> I get:
> 
> <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> 
> … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> 
> Very odd. :-(

Hmm in Firefox 24 it's no longer reproducible here...
Comment 7 James Forrester 2013-10-03 00:21:40 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > I get:
> > 
> > <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> > ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> > 
> > … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> > 
> > Very odd. :-(
> 
> Hmm in Firefox 24 it's no longer reproducible here...

If you can reproduce in Firefox 22 again, once it's in the broken state in the ContentEditable surface please place the cursor to the left (up-page of) the link and insert a new line. This should trigger a re-render and cause the shown HTML to be corrected to what it should be?
Comment 8 Liangent 2013-10-03 00:51:54 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > I get:
> > > 
> > > <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> > > ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> > > 
> > > … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> > > 
> > > Very odd. :-(
> > 
> > Hmm in Firefox 24 it's no longer reproducible here...
> 
> If you can reproduce in Firefox 22 again, once it's in the broken state in
> the
> ContentEditable surface please place the cursor to the left (up-page of) the
> link and insert a new line. This should trigger a re-render and cause the
> shown
> HTML to be corrected to what it should be?

Unfortunatly I don't know how to get it back now :(

I simply APT updated it. Does any have some hint about downgrading a package?
Comment 9 James Forrester 2013-10-03 00:59:35 UTC
I downloaded versions 21, 22 and 23 from: https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/21.0/ (etc.)

I didn't get your reported behaviour in any of them. :-(
Comment 10 D Chan 2013-10-08 23:01:28 UTC
I do not get the reported problem in Firefox 18 (And Chromium 25).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links