Last modified: 2013-10-15 09:09:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56901, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54901 - TimedText's background clashes with the text
TimedText's background clashes with the text
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-02 22:49 UTC by Rainer Rillke @commons.wikimedia
Modified: 2013-10-15 09:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot showing the issue: TMH at Wikimedia Commons (138.30 KB, image/jpeg)
2013-10-02 22:51 UTC, Rainer Rillke @commons.wikimedia
Details
Screenshot showing how it will look like after applying this patch at Wikimedia Commons (script injected through Fiddler2) (109.21 KB, image/jpeg)
2013-10-02 22:52 UTC, Rainer Rillke @commons.wikimedia
Details

Description Rainer Rillke @commons.wikimedia 2013-10-02 22:49:29 UTC
Currently TimedText sometimes uses a bigger font-size but not a bigger 
line-height. This sometimes causes TimedText's background to clash with
the text resulting in horizontally cut-off texts.

Patch follows immediately.
Comment 1 Gerrit Notification Bot 2013-10-02 22:49:57 UTC
Change 87284 had a related patch set uploaded by Rillke:
Prevent background overflowing TimeText

https://gerrit.wikimedia.org/r/87284
Comment 2 Rainer Rillke @commons.wikimedia 2013-10-02 22:51:38 UTC
Created attachment 13427 [details]
Screenshot showing the issue: TMH at Wikimedia Commons
Comment 3 Rainer Rillke @commons.wikimedia 2013-10-02 22:52:39 UTC
Created attachment 13428 [details]
Screenshot showing how it will look like after applying this patch at Wikimedia Commons (script injected through Fiddler2)
Comment 4 Rainer Rillke @commons.wikimedia 2013-10-13 20:21:28 UTC
For the sake of completeness, here is how to reproduce:
* Use Windows 7 and Mozilla Firefox
* Go to https://commons.wikimedia.org/wiki/File:2013-09-28_President_Obama's_Weekly_Address_HD.webm
* Click full screen
* Make sure subtitles are enabled
* Play the file
* At second 43, the text clashes

So if you don't want patches or bug reports tell it right away.
Comment 5 Gerrit Notification Bot 2013-10-14 18:12:53 UTC
Change 87284 merged by Mdale:
Prevent background overflowing TimeText

https://gerrit.wikimedia.org/r/87284
Comment 6 Michael Dale 2013-10-14 18:18:39 UTC
Thanks reviewed and merged. 
https://gerrit.wikimedia.org/r/#/c/87284/

Also patched up-stream. 
https://github.com/kaltura/mwEmbed/commit/3fe927af7a0eb5cf63186be5b66943d25c0235a1

Apologies for the delay, and thanks again :)
Comment 7 Andre Klapper 2013-10-15 09:09:39 UTC
(In reply to comment #6)
> Thanks reviewed and merged. 
> https://gerrit.wikimedia.org/r/#/c/87284/

Closing as RESOLVED FIXED. Fix will be deployed on Wikimedia servers as per https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links