Last modified: 2014-01-18 01:09:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56903, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54903 - VisualEditor: JavaScript crashes if an invalid keyword is used on an image
VisualEditor: JavaScript crashes if an invalid keyword is used on an image
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-01-02
Assigned To: Roan Kattouw
https://en.wikipedia.org/wiki/User:Am...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-02 23:02 UTC by Amir E. Aharoni
Modified: 2014-01-18 01:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-10-02 23:02:40 UTC
To reproduce, go to the URL ([[User:Amire80/ve-invalid-image-keyword]]). Notice that the save button doesn't appear in the toolbar. The JS console shows the following error:

[15:59:08.469] Error: Offset could not be translated to a DOM element and offset: 3

The reason for this is the invalid keyword "no_such_keyword" that I used on the image.

A better behavior would be to show the user some kind of a warning about the wrong keyword, rather than throwing a JS error and crashing.

This bug was discovered by User:Nurick in the Hebrew Wikipedia.
Comment 1 Roan Kattouw 2014-01-05 09:43:57 UTC
This seems to have occurred because we tried to put the selection inside the image caption, which then caused an error. For whatever reason, this doesn't seem to be happening any more; opening your test page in VE doesn't reproduce the error now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links