Last modified: 2014-10-14 17:38:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56906, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54906 - VisualEditor: Append references list to bottom of pages when first reference is added
VisualEditor: Append references list to bottom of pages when first reference ...
Status: PATCH_TO_REVIEW
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-nextup
Assigned To: Alex Monk
:
: 58049 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-02 23:50 UTC by Jared Zimmerman (WMF)
Modified: 2014-10-14 17:38 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jared Zimmerman (WMF) 2013-10-02 23:50:30 UTC
"References" or local wiki language equivalent section and {{reflist}} template should be added if it does not exist to the bottom of pages when the first reference is added to a page with visual editor rather than displaying 

"Cite error: <ref> tags exist, but no <references/> tag was found"
Comment 1 James Forrester 2013-10-02 23:53:06 UTC
We've discussed adding the reference list (note: NOT {{reflist}}) automatically to the end, but I'm not so sure about adding local wiki structures as it would be a real mess to maintain.
Comment 2 James Forrester 2014-02-27 22:50:17 UTC
*** Bug 58049 has been marked as a duplicate of this bug. ***
Comment 3 Jared Zimmerman (WMF) 2014-02-27 23:19:20 UTC
I worry that this will cause issues if the references are added manually, rather than through the {{Reflist}} template that we'll be creating an inconsistency and moving in a direction that we don't want to go it (I don't know if we want to go in this direction at all)
Comment 4 James Forrester 2014-02-28 00:28:18 UTC
(In reply to Jared Zimmerman (WMF) from comment #3)
> I worry that this will cause issues if the references are added manually,
> rather than through the {{Reflist}} template that we'll be creating an
> inconsistency and moving in a direction that we don't want to go it (I don't
> know if we want to go in this direction at all)

References should *never* be added through the {{reflist}} template (which itself should *never* be used) in VisualEditor… Hence the huge amount of work we're doing to make the new citation inserting system and improve the existing citations system to obviate the need for the use of templates as hacks around deficiencies in the system.
Comment 5 Alex Monk 2014-05-30 19:49:10 UTC
If wikis use their own template instead of using <references /> directly, this doesn't sound like a good idea...
Comment 6 Jared Zimmerman (WMF) 2014-05-30 19:56:19 UTC
Will <references /> break or display an error or will it just look different in the wikitext than what they are used to?
Comment 7 Alex Monk 2014-05-30 20:13:34 UTC
It 'just' looks different in most cases, as far as I'm aware.
Comment 8 James Forrester 2014-05-30 20:18:47 UTC
(In reply to Alex Monk from comment #5)
> If wikis use their own template instead of using <references /> directly,
> this doesn't sound like a good idea...

This is why bug 51260 exists.
Comment 9 Jared Zimmerman (WMF) 2014-05-30 21:01:08 UTC
So if it's a difference in the look or style of the wikitext only. And the resolution is fewer or no errors for end users, then this seems like an easy choice to make.
Comment 10 James Forrester 2014-05-30 21:09:42 UTC
I disagree that this is blocked by bug 51260; this bug will avoid breakage for users (who insert references and don't know to insert a reference list), whereas bug 51260 is a nice-to-have set of options around styling said reference list.
Comment 11 James Forrester 2014-05-30 21:10:42 UTC
Removing "section"; this is totally un-do-able in a scalable fashion.
Comment 12 Alex Monk 2014-05-30 21:21:27 UTC
(In reply to Jared Zimmerman (WMF) from comment #9)
> So if it's a difference in the look or style of the wikitext only. And the
> resolution is fewer or no errors for end users, then this seems like an easy
> choice to make.

I agree with you, but it doesn't sound like it will be that uncontroversial in wiki communities.
Comment 13 Jared Zimmerman (WMF) 2014-05-30 21:53:08 UTC
Saying this depends on native VE support of multi-column reflists before fixing it is rediculous as saying native gallery support is required before we handle individual image insertion without an error. Let's walk before we run, and think of the audience before we get too hung up in site politics. The VE inserted references object can be seen as a placeholder for someone *if* they want to swap it out for something site specific but it doesn't seem like a blocker for this by any stretch of the imagination when the alternative is throwing up errors to the use or not displaying a reflist at all.
Comment 14 Jared Zimmerman (WMF) 2014-05-31 00:48:31 UTC
Alex, I realized after a bit that this may have sounded like it was (angrily) directed at you rather than just general frustration at unfixed bugs. Just wanted to appogize if it sounded like that to you too. I definitely don't want to be a part of the negative culture we sometime have, and wanted to clear that up. Again sorry if that seemed directed at you.
Comment 15 Alex Monk 2014-05-31 01:08:43 UTC
It's fine, I'm just not convinced this is a good idea with:

* the current state of {{reflist}} (or equivalent) vs. <references />
* the assumption that references will always be at the absolute bottom of the page (often it's followed by external links, subject navigation templates, etc.)
* making changes to the document without the user explicitly triggering them

Perhaps it would be okay with some detailed explanation to the user (maybe a warning beforehand, perhaps with a checkbox they can untick to prevent it or something, or maybe just a notification dialog of some sort after it's done). But we it should be clearly thought out and established here how that should be handled.

Right now, VE does the same thing as the wikitext editor in this respect - i.e. nothing. Perhaps even just a note on the new reference dialog saying "You'll need to add a <references />/{{reflist}} otherwise this will error when saving." could solve the underlying issue here.
Comment 16 Erik Moeller 2014-06-19 05:06:36 UTC
Why not treat references like the TOC and always have MediaWiki output them at the bottom of the page (or section when in preview mode in wikitext) unless a <references/> tag is present?
Comment 17 James Forrester 2014-06-19 22:43:00 UTC
(In reply to Erik Moeller from comment #16)
> Why not treat references like the TOC and always have MediaWiki output them
> at the bottom of the page (or section when in preview mode in wikitext)
> unless a <references/> tag is present?

Nice idea; I've created this as bug 66860.
Comment 18 Gerrit Notification Bot 2014-07-25 22:00:03 UTC
Change 149117 had a related patch set uploaded by Jforrester:
[WIP] If there isn't one already, append reference list to page when creating a reference

https://gerrit.wikimedia.org/r/149117

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links