Last modified: 2014-06-17 17:04:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56930, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 54930 - Labels for checkboxes/radiobuttons should appear inline


Summary:	Labels for checkboxes/radiobuttons should appear inline

Status:	RESOLVED WORKSFORME

Product:	MediaWiki skins
Classification:	Unclassified
Component:	Chameleon (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor
Target Milestone:	---
Assigned To:	Huji

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-03 19:08 UTC by Huji
Modified:	2014-06-17 17:04 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Huji 2013-10-03 19:08:28 UTC

Right now, the labels appear on the next line, which is counter intuitive and wastes a lot of space.

Consider using   label{display:inline-block;}   in the CSS for this skin.

Comment 1 Gerrit Notification Bot 2013-10-07 22:02:56 UTC

Change 88240 had a related patch set uploaded by Huji:
(bug 54930) Labels for checkboxes/radiobuttons should appear inline

https://gerrit.wikimedia.org/r/88240

Comment 2 s7eph4n 2013-10-07 22:08:27 UTC

Is this still an issue. E.g. preferences look alright now.

Comment 3 Huji 2013-10-07 22:10:05 UTC

*After* applying patch 88240, yes, they do look alright.

Comment 4 s7eph4n 2013-10-07 22:17:16 UTC

This is my prefs page using current master (b06f286): http://imageshack.com/a/img849/5377/1pqh.png

What's wrong with that?

Comment 5 s7eph4n 2013-10-07 22:18:53 UTC

In fact, bootstrap has exactly your proposed rule:

label {
    display: inline-block;
    font-weight: bold;
    margin-bottom: 5px;
}

Comment 6 Huji 2013-10-08 02:43:21 UTC

Oh well, I did two separate installations of Chameleon and in both cases, the labels were NOT shown on the same line as the checkboxes. Let me try to figure out where the bug is.

Comment 7 Huji 2013-10-08 23:59:34 UTC

It may be because I was using Bootstrap 2.3.x because now that I updated to Bootstrap 3, I see what you see. Closing the bug as WORKSFORME.

Comment 8 Gerrit Notification Bot 2013-10-20 14:55:58 UTC

Change 88240 abandoned by Foxtrott:
(bug 54930) Labels for checkboxes/radiobuttons should appear inline

Reason:
Bug was closed as WORKSFORME.

https://gerrit.wikimedia.org/r/88240

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links