Last modified: 2013-12-05 04:49:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56936, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54936 - Defer all references to Special:Flow into UrlGenerator
Defer all references to Special:Flow into UrlGenerator
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-03 20:31 UTC by Erik Bernhardson
Modified: 2013-12-05 04:49 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Erik Bernhardson 2013-10-03 20:31:37 UTC 
UrlGenerator is now the go-to place to get links for a particular workflow.  It has the smarts to link appropriatly to either Special:Flow or the article itself if we have occupied it.  Anywhere that explicitly references Special:Flow should be ported to either UrlGenerator, or if that doesn't make any sense use the OccupationController
Comment 1 Erik Bernhardson 2013-10-03 21:03:53 UTC 
I suppose i missed a bit in the previous comment,  what i mean is for example

Workflow::getTitle and Workflow::getArticleTitle,  moving forward getArticleTitle should be deprecated and getTitle should return what getArticleTitle currently does.  We can't just change one line though, someone needs to look through all places that either reference NS_SPECIAL, Special, or SpecialPage.
Comment 2 spage 2013-10-05 01:35:43 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/295
Comment 3 Gerrit Notification Bot 2013-10-14 02:33:38 UTC 
Change 89612 had a related patch set uploaded by Werdna:
Fix bug 54936: Redirect most references to Special:Flow through UrlGenerator

https://gerrit.wikimedia.org/r/89612
Comment 4 Gerrit Notification Bot 2013-10-14 13:06:12 UTC 
Change 89612 merged by jenkins-bot:
Fix bug 54936: Redirect most references to Special:Flow through UrlGenerator.

https://gerrit.wikimedia.org/r/89612
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links