Last modified: 2013-10-05 21:35:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56955, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 54955 - weird &1 in HTML comment
weird &1 in HTML comment
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MassMessage (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-04 05:40 UTC by Kunal Mehta (Legoktm)
Modified: 2013-10-05 21:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2013-10-04 05:40:00 UTC 
<!-- Message sent by User:Eloquence@testwiki using the list at //test.wikipedia.org/w/index.php?title=User:Eloquence/MM&1 -->

The &1 shouldn't be there.

> echo Title::newFromText('Main Page')->getFullURL();
http://127.0.0.1:8080/wiki/Main_Page
> echo Title::newFromText('Main Page')->getFullURL($proto = PROTO_CANONICAL);
http://127.0.0.1:8080/w/index.php?title=Main_Page&1

I think this is because I didn't realize PHP doesn't support out of order kwargs like python does.
Comment 1 Gerrit Notification Bot 2013-10-04 05:42:34 UTC 
Change 87509 had a related patch set uploaded by Legoktm:
Use PROTO_CANONICAL correctly.

https://gerrit.wikimedia.org/r/87509
Comment 2 Gerrit Notification Bot 2013-10-05 21:32:47 UTC 
Change 87509 merged by jenkins-bot:
Use PROTO_CANONICAL correctly.

https://gerrit.wikimedia.org/r/87509
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links