Last modified: 2014-03-19 15:50:11 UTC
Hi, the GRAMMAR variable for Slovene language, the cases 'mestnik' and 'orodnik', currently includes the prepositions (o and z). These depend on the context and should therefore be left out of the default pattern. Mestnik: * o Wikipediji > Wikipediji Orodnik: * z Wikipedijo > Wikipedijo Etc. Thank you.
Please have a look at https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fclasses%2FLanguageSl.php It seems like the current implementation is correct?
It doesn't seem: Locativ: "word = 'o ' . $word" - this "o" is redundant Instrumental: "word = 'z ' . $word;" - this "z" is redundant
Created attachment 14859 [details] Removed hard-coded prepositions from grammar function Patched file https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fclasses%2FLanguageSl.php.
Created attachment 14860 [details] Removed prepositions from Slovene grammar forms Patched file http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikimediaMessages.git/HEAD/WikimediaGrammarForms.php. (I also saw that 'rmy' language uses Slovene grammar forms for dative, locative, ablative and instrumental, which is probably a copy-paste error.)
I have uploaded two patches that fix this bug.
I just saw that my patched LanguageSl::convertGrammar() is same as Language::convertGrammar(), so file languages/classes/LanguageSl.php can be completely removed.
