Last modified: 2013-11-20 11:08:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56964, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54964 - VisualEditor: Outer whitespace of first/last node in document not validated
VisualEditor: Outer whitespace of first/last node in document not validated
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-11-21
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-04 09:49 UTC by Ed Sanders
Modified: 2013-11-20 11:08 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-10-04 09:49:00 UTC
Because we don't store the inner whitespace of the document, we can't validate the outer whitespace its first/last children.

1. Create document with wikitext:
==Heading==
Foo
2. Delete 'Heading' and the empty line
3. You now have:
[{'type':'paragraph', 'internal': {'whitepsace': ['\n']}}, 'F' ....
in the DM
4. This serialises to
\n
Foo
Comment 1 Wikifram@gmail.com (Account disabled) 2013-10-04 09:55:21 UTC
Translation for those looking to file a similar bug but no so well-versed in code-speak :-): 

When you have a blank line at the start of an article, before the text of the lead, it is impossible in VE to remove this line or lines. See e.g. [https://en.wikipedia.org/w/index.php?title=User%3AFram%2Fsandbox&diff=575706125&oldid=575706080]
Comment 2 Gerrit Notification Bot 2013-10-31 15:54:11 UTC
Change 92885 had a related patch set uploaded by Esanders:
Store inner whitespace of the body and compare it on conversion

https://gerrit.wikimedia.org/r/92885
Comment 3 Gerrit Notification Bot 2013-11-20 10:45:06 UTC
Change 92885 merged by jenkins-bot:
Store inner whitespace of the body and compare it on conversion

https://gerrit.wikimedia.org/r/92885

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links