Last modified: 2013-10-07 17:30:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56973, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54973 - README incorrect
README incorrect
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
master
Other Linux
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-04 14:06 UTC by keyler
Modified: 2013-10-07 17:30 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description keyler 2013-10-04 14:06:15 UTC
1. Here are 2 mistakes, one in the directory name and one in the file name!

 php maintenance/updateSearchConfig.php --> php extensions/CirrusSearch/updateSearchIndexConfig.php

2. Here just the wrong path is written in the README

 php maintenance/forceSearchIndex.php --> php extensions/CirrusSearch/forceSearchIndex.php
Comment 1 Gerrit Notification Bot 2013-10-04 15:18:39 UTC
Change 87578 had a related patch set uploaded by Chad:
Move maintenance scripts out of top level

https://gerrit.wikimedia.org/r/87578
Comment 2 keyler 2013-10-04 15:50:32 UTC
Great, thank you.

One more thing: I would suggest to mention in the README that one now needs "Extension: Elastica" for CirrusSearch to work.
Comment 3 Gerrit Notification Bot 2013-10-04 19:39:17 UTC
Change 87578 merged by jenkins-bot:
Move maintenance scripts out of top level

https://gerrit.wikimedia.org/r/87578
Comment 4 Chad H. 2013-10-04 19:42:53 UTC
(In reply to comment #2)
> One more thing: I would suggest to mention in the README that one now needs
> "Extension: Elastica" for CirrusSearch to work.

Also done: https://gerrit.wikimedia.org/r/#/c/87614/

Thanks for the bug report!
Comment 5 keyler 2013-10-04 20:40:31 UTC
Perfect! Thank YOU for the fast fixing...
Comment 6 keyler 2013-10-05 09:05:59 UTC
Since the move to the maintenance folder the .php file does not work anymore:

root@alpha /var/www/wiki/extensions/CirrusSearch # php ./maintenance/updateSearchIndexConfig.php

PHP Warning:  require_once(/var/www/wiki/extensions/CirrusSearch/maintenance/../../maintenance/Maintenance.php): failed to open stream: No such file or directory in /var/www/wiki/extensions/CirrusSearch/maintenance/updateSearchIndexConfig.php on line 25
PHP Fatal error:  require_once(): Failed opening required '/var/www/wiki/extensions/CirrusSearch/maintenance/../../maintenance/Maintenance.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/wiki/extensions/CirrusSearch/maintenance/updateSearchIndexConfig.php on line 25
Comment 7 Nik Everett 2013-10-07 16:58:33 UTC
Merged this: https://gerrit.wikimedia.org/r/#/c/88127/ which should fix the paths.

Part of the problem with this is that mw developers tend to check out extensions in another tree and symlink them into the mediawiki tree.  In that case those paths are relative to the symlink which isn't helpful.  So we always set MW_INSTALL_PATH.  So this doesn't get checked as much as it should.
Comment 8 Chad H. 2013-10-07 17:02:23 UTC
(In reply to comment #7)
> Merged this: https://gerrit.wikimedia.org/r/#/c/88127/ which should fix the
> paths.
> 
> Part of the problem with this is that mw developers tend to check out
> extensions in another tree and symlink them into the mediawiki tree.  In that
> case those paths are relative to the symlink which isn't helpful.  So we
> always
> set MW_INSTALL_PATH.  So this doesn't get checked as much as it should.

Actually it was just me cutting corners and not testing ;-)
Comment 9 keyler 2013-10-07 17:07:01 UTC
:-) thank you again Nik and Chad.
Now I only have to wait until i can "git pull" the changes.
Up to now the changes are not in "master" but I will just wait until tomorrow.

Keep up the GREAT WORK!
Comment 10 Nik Everett 2013-10-07 17:18:20 UTC
keyler, where are you pulling from?  They are certainly in master on Gerrit here:  https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/CirrusSearch
Comment 12 keyler 2013-10-07 17:22:48 UTC
and this pops up when I try your path: 

git clone https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/CirrusSearch

Cloning into 'CirrusSearch'...
fatal: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/CirrusSearch/info/refs not valid: is this a git repository?
Comment 13 Nik Everett 2013-10-07 17:23:59 UTC
This is the clone command I use:

git clone https://gerrit.wikimedia.org/r/mediawiki/extensions/CirrusSearch
Comment 14 keyler 2013-10-07 17:30:47 UTC
Download works now. Thank you.


PS: my bad: it was already up to date, just did not realize it....
OUPPPPS :-(

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links