Last modified: 2013-10-04 18:24:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T56987, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 54987 - "Publish and submit" button shouldn't be available because it shouldn't be used
"Publish and submit" button shouldn't be available because it shouldn't be used
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-04 18:22 UTC by Brion Vibber
Modified: 2013-10-04 18:24 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2013-10-04 18:22:04 UTC
Per discussion with Krinkle on IRC, the "publish and submit" button in Gerrit should not be used.

If this is the case, it should not be present.
Comment 1 Krinkle 2013-10-04 18:24:58 UTC
* Our Gerrit config requires V+2 to be present. We can change Jenkins to do V+1 on the patch test so that it doens't clash with the V+2 vote for the submit test, that resolves the ambiguity and will make the submit button not appear before it should.

* Alternatively, like for various repositories already (including VisualEditor) we could remove the "Submit" right from regular users (e.g. only for JenkinsBot and l10nbot, and some ops maybe).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links