Last modified: 2014-03-08 07:43:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57152, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55152 - Recentchanges misbehave?
Recentchanges misbehave?
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-05 04:34 UTC by Kunal Mehta (Legoktm)
Modified: 2014-03-08 07:43 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-10-05 04:34:06 UTC
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1579/
Reported by: Anonymous user
Created on: 2013-02-13 09:41:03
Subject: Recentchanges misbehave?
Original description:
There are two bugs I found in recentchanges\(\) from wikipedia.py.

First, I think that the function should return every revision. However, now it returns only pages that haven't seen before.

Should

if i\['pageid'\] not in seen:
seen.add\(i\['pageid'\]\) 

be replaced with

if i\['revid'\] not in seen:
seen.add\(i\['revid'\]\) 

?

Second, what does parameter 'includeredirects' stand for? It is useless becaue it isn't used anywhere in the function. 

Pywikipedia trunk/pywikipedia/ \(r11072, 2013/02/10, 16:52:07, ok\)
Python 2.7.3 \(default, Sep 26 2012, 21:53:58\) 
\[GCC 4.7.2\]
config-settings:
use\_api = True
use\_api\_login = True
unicode test: ok
Comment 1 Gerrit Notification Bot 2014-02-06 18:40:16 UTC
Change 111832 had a related patch set uploaded by Nullzero:
Make Recentchanges return all revisions

https://gerrit.wikimedia.org/r/111832
Comment 2 Gerrit Notification Bot 2014-03-01 02:54:35 UTC
Change 111832 had a related patch set uploaded by Nullzero:
Make Recentchanges return all revisions

https://gerrit.wikimedia.org/r/111832
Comment 3 Gerrit Notification Bot 2014-03-01 03:14:15 UTC
Change 116218 had a related patch set uploaded by Nullzero:
Make Recentchanges be able to return all revisions

https://gerrit.wikimedia.org/r/116218
Comment 4 Gerrit Notification Bot 2014-03-01 03:15:38 UTC
Change 111832 abandoned by Nullzero:
Make Recentchanges return all revisions

Reason:
Can't rebase -- create a new one instead

https://gerrit.wikimedia.org/r/111832
Comment 5 Gerrit Notification Bot 2014-03-01 05:59:57 UTC
Change 116218 merged by jenkins-bot:
Make Recentchanges be able to return all revisions

https://gerrit.wikimedia.org/r/116218

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links