Last modified: 2014-06-01 10:02:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57161, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55161 - do not insert a space between "#" and "REDIRECT"
do not insert a space between "#" and "REDIRECT"
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
Cosmetic changes (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Ricordisamoa
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-05 04:35 UTC by Kunal Mehta (Legoktm)
Modified: 2014-06-01 10:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2013-10-05 04:35:37 UTC 
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1545/
Reported by: jandudik
Created on: 2012-11-28 10:51:03
Subject: pageform file and cosmetic changes
Original description:
I tried to made several redirects:
pagefromfile.py -start:XXX -end:XXX -file:hsb.txt -notitle -lang:hsb

where hsb.txt contained
XXX
'''Carex dioica'''
\#REDIRECT\[\[dwójna rězna\]\]
YYY
...

But bot imported article with cosmetic chages and there isn't \#REDIRECT but \# REDIRECT
http://hsb.wikipedia.org/w/index.php?title=Carex\_dioica&oldid=274441
Comment 1 Kunal Mehta (Legoktm) 2013-10-05 04:35:39 UTC 
the easiest way is to switch off cosmetic\_changes when creating redirect pages. If cc is enabled by default you can use
pagefromfile.py -start:XXX -end:XXX -file:hsb.txt -notitle -lang:hsb -cc

If the page already exists that changes will not be made.
Comment 2 Kunal Mehta (Legoktm) 2013-10-05 04:35:41 UTC 
- **priority**: 5 --> 3
Comment 3 Kunal Mehta (Legoktm) 2013-10-05 04:35:43 UTC 
Disabling of a feature always solves problems with it. But it would be nice to fix cosmetic changes module so that it doesn't add a whitespace after \# in magic words and parser functions.
Comment 4 Kunal Mehta (Legoktm) 2013-10-05 04:35:45 UTC 
I aggree. But disabling that feature is the most easiest way to solve it ;\)
Comment 5 Ricordisamoa 2014-04-16 03:22:02 UTC 
CosmeticChangesToolkit.putSpacesInLists() seems to be concerned.
Comment 6 Gerrit Notification Bot 2014-05-24 02:38:35 UTC 
Change 135166 had a related patch set uploaded by Ricordisamoa:
exclude redirects from CosmeticChangesToolkit.putSpacesInLists()

https://gerrit.wikimedia.org/r/135166
Comment 7 Gerrit Notification Bot 2014-05-25 12:22:26 UTC 
Change 135166 merged by jenkins-bot:
exclude redirects from CosmeticChangesToolkit.putSpacesInLists()

https://gerrit.wikimedia.org/r/135166
Comment 8 Gerrit Notification Bot 2014-06-01 09:18:00 UTC 
Change 136627 had a related patch set uploaded by Ricordisamoa:
backport Ic8ef2868ef9c55a1cec57a17f5601652918a62c7 from core

https://gerrit.wikimedia.org/r/136627
Comment 9 Gerrit Notification Bot 2014-06-01 10:02:01 UTC 
Change 136627 merged by jenkins-bot:
backport Ic8ef2868ef9c55a1cec57a17f5601652918a62c7 from core

https://gerrit.wikimedia.org/r/136627
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links