Last modified: 2014-09-06 23:46:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57264, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55264 - SpamFilter error not raising
SpamFilter error not raising
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-05 04:53 UTC by Kunal Mehta (Legoktm)
Modified: 2014-09-06 23:46 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-10-05 04:53:41 UTC
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1217/
Reported by: betacommand
Created on: 2010-08-06 00:04:04
Subject: SpamFilter error not raising
Original description:
this is related to https://sourceforge.net/tracker/?func=detail&aid=3028176&group\_id=93107&atid=603138 pywikipedia quietly fails when triggering the spam filter 
\{u'edit': \{u'spamblacklist': u'http://www.gamerbrain.net', u'result': u'Failure'\}\}
is one example of the returned tuple either the API changed or someone broke something

Python 2.6.5 \(r265:79063, Apr 16 2010, 13:09:56\) 
\[GCC 4.4.3\]
config-settings:
use\_api = True
use\_api\_login = True
Comment 1 Gerrit Notification Bot 2014-08-19 08:34:35 UTC
Change 154992 had a related patch set uploaded by John Vandenberg:
SpamfilterError does not work

https://gerrit.wikimedia.org/r/154992
Comment 2 Gerrit Notification Bot 2014-08-19 09:18:10 UTC
Change 141398 had a related patch set uploaded by John Vandenberg:
Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398
Comment 3 Gerrit Notification Bot 2014-09-06 15:34:44 UTC
Change 141398 merged by XZise:
Page save related exception hierarchy

https://gerrit.wikimedia.org/r/141398
Comment 4 Gerrit Notification Bot 2014-09-06 23:45:07 UTC
Change 154992 abandoned by John Vandenberg:
SpamfilterError does not work

Reason:
Shit; this changeset should have been merged before Id8b8c8055100329e7844b5db6500f71bbb1673f7 (mentioned in comment on Aug 19 7:20 PM), which also included the fixed version.

http://git.wikimedia.org/blobdiff/pywikibot%2Fcore.git/c07c8da00cef8e189762ccf4f46422f6bb6f5d5f/pywikibot%2Fsite.py#L3541

https://gerrit.wikimedia.org/r/154992
Comment 5 John Mark Vandenberg 2014-09-06 23:46:13 UTC
Fixed in https://gerrit.wikimedia.org/r/#/c/141398

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links