Last modified: 2013-11-06 05:03:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57290, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55290 - Patch I submitted for djvutext.py was not applied correctly
Patch I submitted for djvutext.py was not applied correctly
Status: RESOLVED INVALID
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-05 04:58 UTC by Kunal Mehta (Legoktm)
Modified: 2013-11-06 05:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-10-05 04:58:08 UTC
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1112/
Reported by: dischead
Created on: 2010-01-08 19:37:48
Subject: Patch I submitted for djvutext.py was not applied correctly
Original description:
In ID 2927811, I submitted a patch to djvutext.py so that it would call DjVuLibre's djvutxt binary with correct command-line options.

A change was checked into Subversion \(r7865\).  However, this change was incorrect.  It's possible that the edit was made by hand rather than applying the patch I provided.

The "--page" option to djvutxt must have a space instead of an equals sign between itself and the page number.  If an equals sign is there, djvutxt will ignore the option and dump ALL text in the given DjVu file.  This is likely to cause incorrect behavior in djvutext.py.

So all that's needed is to change the equals sign to a space.  I'm attaching a new patch, but I think this can be done by hand. ;-\)

Thanks\!
Comment 1 Kunal Mehta (Legoktm) 2013-10-05 04:58:10 UTC
Re-fix usage of DjVuLibre's djvutxt binary
Comment 2 Gerrit Notification Bot 2013-10-25 14:06:09 UTC
Change 91868 had a related patch set uploaded by Ladsgroup:
a minor fix for djvutext.py

https://gerrit.wikimedia.org/r/91868
Comment 3 Amir Ladsgroup 2013-11-06 05:02:47 UTC
1- It's against the documentation: http://djvu.sourceforge.net/doc/man/djvutxt.html

2- I checked and It didn't work in your way but It worked when I used "=" (the old system.
http://fa.wikisource.org/wiki/%D8%A8%D8%B1%DA%AF%D9%87:Ladsgroup/1

So I close this bug as INVALID
Comment 4 Gerrit Notification Bot 2013-11-06 05:03:07 UTC
Change 91868 abandoned by Ladsgroup:
a minor fix for djvutext.py

Reason:
You're right I checked it

https://gerrit.wikimedia.org/r/91868

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links