Last modified: 2013-10-25 17:50:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57373, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 55373 - InlineHistory "marked as a duplicate" detection too eager


Summary:	InlineHistory "marked as a duplicate" detection too eager

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Bugzilla (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Andre Klapper

URL:
Whiteboard:
Keywords:	upstream

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-06 18:23 UTC by Bartosz Dziewoński
Modified:	2013-10-25 17:50 UTC (History)
CC List:	5 users (show)

See Also:	https://bugzilla.mozilla.org/show_bug.cgi?id=928387
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Bartosz Dziewoński 2013-10-06 18:23:17 UTC

I've been reading bug 45051, caressing my ego, when I noticed…

Below bug 45051 comment 6, InlineHistory claims that MZMcBride marked a bug as a duplicate of that one. This is not true; Krinkle did that in comment 5, and MZMcBride only quoted the automatic comment.

The only explanation I see is that InlineHistory "marked as a duplicate" detection is too eager. It should only trigger when that comment is at the end of the comment, in a separate paragraph.

Comment 1 Andre Klapper 2013-10-08 12:31:06 UTC

Interesting. Probably should go upstream as I didn't change any code. Only slightly related ticket I could find was https://bugzilla.mozilla.org/show_bug.cgi?id=759768

Comment 2 Andre Klapper 2013-10-18 14:22:09 UTC

Upstreamed as https://bugzilla.mozilla.org/show_bug.cgi?id=928387

Comment 3 Andre Klapper 2013-10-21 09:25:24 UTC

I (or anybody) need to create a similar testcase (bug report) on http://boogs.wmflabs.org and then apply https://bug928387.bugzilla.mozilla.org/attachment.cgi?id=819545 on http://boogs.wmflabs.org to test if it fixes the issue.

Comment 4 Gerrit Notification Bot 2013-10-23 09:59:37 UTC

Change 91362 had a related patch set uploaded by Aklapper:
Fix InlineHistory's "marked as a duplicate" detection being too eager

https://gerrit.wikimedia.org/r/91362

Comment 5 Gerrit Notification Bot 2013-10-25 17:21:03 UTC

Change 91362 merged by Dzahn:
Fix InlineHistory's "marked as a duplicate" detection being too eager

https://gerrit.wikimedia.org/r/91362

Comment 6 Daniel Zahn 2013-10-25 17:22:15 UTC

this has been deployed.

Comment 7 Bartosz Dziewoński 2013-10-25 17:50:17 UTC

Thank you! The issue described in comment 0 is fixed now.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links