Last modified: 2013-10-10 22:16:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57376, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55376 - CLI Installer should *not* set wgServer if it is not explicitly passed
CLI Installer should *not* set wgServer if it is not explicitly passed
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-06 18:44 UTC by Yuvi Panda
Modified: 2013-10-10 22:16 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yuvi Panda 2013-10-06 18:44:32 UTC 
Right now, if no --server-url is passed to the CLI installer, it attempts to guess. Since there is not enough information for it to guess correctly, it usually puts up a rather bad guess (localhost, mostly). If, however, we do not guess, and just not set a wgServer, WebRequest will do the guessing - and its guesses are far more accurate, since it has more information to work with.

So if there's no --server-url passed, wgServer shouldn't be set.
Comment 1 Yuvi Panda 2013-10-06 19:13:54 UTC 
I meant --server, not --server-url.
Comment 2 Gerrit Notification Bot 2013-10-06 19:43:48 UTC 
Change 87887 had a related patch set uploaded by Yuvipanda:
Do not set wgServer in cli install unless explicitly passed

https://gerrit.wikimedia.org/r/87887
Comment 3 Gerrit Notification Bot 2013-10-10 22:12:57 UTC 
Change 87887 merged by jenkins-bot:
Do not set wgServer in cli install unless explicitly passed

https://gerrit.wikimedia.org/r/87887
Comment 4 Yuvi Panda 2013-10-10 22:16:13 UTC 
Wooo, merged!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links