Last modified: 2014-03-23 13:27:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57386, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55386 - "Other languages" box in Translate extension should use divs instead of an HTML table
"Other languages" box in Translate extension should use divs instead of an HT...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Lowest minor (vote)
: ---
Assigned To: kunalgrover05
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-07 01:40 UTC by MZMcBride
Modified: 2014-03-23 13:27 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-10-07 01:40:19 UTC
<languages /> in [[mw:Extension:Translate]] appears to output:

---
<table>
<tbody>
<tr valign="top">
<td class="mw-pt-languages-label">Other languages:</td>
<td class="mw-pt-languages-list"><a href="/wiki/CodeEditor/be-tarask" title="CodeEditor/be-tarask">Belarusian (Taraškievica orthography)</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/cs" title="CodeEditor/cs">Czech</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/de" title="CodeEditor/de">German</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<span class="mw-pt-languages-ui mw-pt-languages-selected">English</span>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/es" title="CodeEditor/es">Spanish</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/fo" title="CodeEditor/fo">Faroese</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-4.png" alt="67%" title="67%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/fr" title="CodeEditor/fr">French</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/gl" title="CodeEditor/gl">Galician</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/hi" title="CodeEditor/hi">Hindi</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/hu" title="CodeEditor/hu">Hungarian</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="83%" title="83%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/it" title="CodeEditor/it">Italian</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="83%" title="83%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/ja" title="CodeEditor/ja">Japanese</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/ko" title="CodeEditor/ko">Korean</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/lb" title="CodeEditor/lb">Luxembourgish</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-1.png" alt="17%" title="17%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/mk" title="CodeEditor/mk">Macedonian</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="83%" title="83%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/mr" title="CodeEditor/mr">Marathi</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-1.png" alt="0%" title="0%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/pl" title="CodeEditor/pl">Polish</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/pt" title="CodeEditor/pt">Portuguese</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/pt-br" title="CodeEditor/pt-br">Brazilian Portuguese</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="83%" title="83%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/ro" title="CodeEditor/ro">Romanian</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="83%" title="83%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/ru" title="CodeEditor/ru">Russian</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-4.png" alt="67%" title="67%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/sv" title="CodeEditor/sv">Swedish</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/uk" title="CodeEditor/uk">Ukrainian</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/vi" title="CodeEditor/vi">Vietnamese</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-1.png" alt="17%" title="17%" width="9" height="9" />&#160;• ‎<a href="/wiki/CodeEditor/zh" title="CodeEditor/zh">Chinese</a>&#160;<img src="//bits.wikimedia.org/static-1.22wmf19/extensions/Translate/resources/images/prog-5.png" alt="100%" title="100%" width="9" height="9" /></td>
</tr>
</tbody>
</table>
---

This shouldn't be using an HTML table. It should instead be using HTML divs.
Comment 1 MZMcBride 2013-10-07 02:08:51 UTC
I missed that it's already using a wrapper div:

<div class="mw-pt-languages noprint" lang="en" dir="ltr" xml:lang="en">...</div>

Table in a div is weird. And the list should be an HTML list, I think (bug 55389).
Comment 2 Niklas Laxström 2013-10-07 06:17:59 UTC
I suggest deferring this to after the redesign of the language bar.
Comment 3 Gerrit Notification Bot 2014-03-23 09:46:29 UTC
Change 120356 had a related patch set uploaded by Kunalgrover05:
Fix language bar design

https://gerrit.wikimedia.org/r/120356
Comment 4 Gerrit Notification Bot 2014-03-23 13:27:15 UTC
Change 120356 merged by jenkins-bot:
Fix language bar design

https://gerrit.wikimedia.org/r/120356
Comment 5 Siebrand Mazeland 2014-03-23 13:27:43 UTC
Thanks, Kunal.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links