Last modified: 2014-09-12 22:27:40 UTC
1) Go to [[Special:Preferences#mw-prefsection-echo]] and disable notifications for thanking 2) Login with another account 3) Pick any edit's diff from the Special:Contributions of the user in step 1 4) Click "thank" and confirm Observed: "thanked" appears instead of the "thank" link. Expected: I'm told that thanking was not possible; or, better, in step (4) I don't see the thank button in the first place.
If we don't show the thanks link, that would technically expose the users preference to not receive thanks. I'm not sure if there is a better alternative than the current method of silently failing.
(In reply to comment #1) > If we don't show the thanks link, that would technically expose the users > preference to not receive thanks. Why would that be a problem? It's what we do with EmailUser, it would not be nice to silently drop emails would it.
There's a distinction between thanking a user and the user receiving a thanks notification, isn't there? The current behavior is to log the thanks and attempt to notify the user of the thanks. If the user has opted out of receiving thanks notifications, that's his or her choice, but he or she was still thanked. Is it appropriate to restrict my ability to thank another editor?
(In reply to comment #3) > There's a distinction between thanking a user and the user receiving a thanks > notification, isn't there? Yes. Aside from logging, a row is created in the echo_event table if you thank a user who has disabled it, just no notification will be created.
*** Bug 70765 has been marked as a duplicate of this bug. ***
In my view the thanks button should be absent in such case. Otherwise whoever thanked me will think that it reached me, but it did not. I prefer when they realise that I got nothing.
