Last modified: 2013-10-14 17:25:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57454, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55454 - JobQueueDB should use SqlBagOStuff for job deduplication / work on vanilla MW install
JobQueueDB should use SqlBagOStuff for job deduplication / work on vanilla MW...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JobQueue (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-08 01:35 UTC by Gabriel Wicke
Modified: 2013-10-14 17:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2013-10-08 01:35:55 UTC 
In the JobQueueDB constructor, caching is basically disabled when SqlBagOStuff is used as $wgMemc:

  // Make sure that we don't use the SQL cache, which would be harmful
  $this->cache = ( $wgMemc instanceof SqlBagOStuff ) ? new EmptyBagOStuff() : $wgMemc;


That means that job deduplication won't work in local testing with the default cache type. Since this is somewhat unexpected behavior it would be great if we could remove this.

Is there still a real performance reason for disabling SqlBagOStuff in JobQueueDB?
Comment 1 Gerrit Notification Bot 2013-10-08 02:31:43 UTC 
Change 88399 had a related patch set uploaded by Aaron Schulz:
Made root job de-duplication work without cache setup

https://gerrit.wikimedia.org/r/88399
Comment 2 Gerrit Notification Bot 2013-10-09 22:21:22 UTC 
Change 88399 merged by jenkins-bot:
Made root job de-duplication work without cache setup

https://gerrit.wikimedia.org/r/88399
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links