Last modified: 2014-04-08 17:38:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57482, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55482 - CSSMin should embed embeddable images by default
CSSMin should embed embeddable images by default
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-08 20:21 UTC by Ori Livneh
Modified: 2014-04-08 17:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-10-08 20:21:49 UTC
CSSMin requires an explicit /* @embed */ directive to trigger image embedding. But embedding embeddable images is almost always desirable, and thus the more sensible behavior would be for image embedding to be opt-out (or, like minification, not optional at all).

Instead of grepping of @embeds, CSSMin could inspect all url()s in the stylesheet to see whether they reference a local, embeddable image file. (An image is embeddable if it is not too large and if CSSMin recognizes its MIME type.) If the referenced is embeddable, CSSMin should simply embed it.

Are there cases for which this behavior would not be desirable? If so, we can replace opt-in via /* @embed */ with opt-out via /* @noembed */. But let's first be sure that we would actually need it.



it has a mime-type is under the size limit and

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links