Last modified: 2014-03-03 02:16:38 UTC
Just like extensions which are usually hosted in a separate repo, skins (other than the default ones) are also often hosted externally. When you checkout these external repos into your working copy of MW, they always get listed in the results of "git status" when that command is run in the higher directory levels (inside MW). This also introduces the risk of incorrectly adding those skins to your patch when you carelessly run "git commit -am ..." I believe these were the reasons we (rightfully) added svnignore in the old days, and .gitignore in the news days, to the /extensions directory. I would like to propose doing the same for the skins directory.
Not a Git/Gerrit bug, marking invalid. Anyone can submit a patch to do this.
Change 88669 had a related patch set uploaded by Huji: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions https://gerrit.wikimedia.org/r/88669
Change 88670 had a related patch set uploaded by Huji: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions https://gerrit.wikimedia.org/r/88670
Change 88669 abandoned by Huji: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions Reason: Duplicate. see https://gerrit.wikimedia.org/r/#/c/88670/ https://gerrit.wikimedia.org/r/88669
Change 88670 had a related patch set uploaded by Bartosz Dziewoński: (bug 55486) Add .gitignore to the /skins directory to make it easier to work on extensions https://gerrit.wikimedia.org/r/88670
Change 88670 merged by jenkins-bot: Add .gitignore to the /skins directory https://gerrit.wikimedia.org/r/88670
Reverted in I77655ea4, new skin files (images etc.) seem to be matches by these rules. I'm going to revert this for now since it's annoying, feel free to resubmit a .gitignore that works.
Do you mean new files for existing skins are being matched? If that is the case, I will fix it with a wild card. If you are talking about adding a "new" skin to the core, then all that is needed is to add the relevant rule to the .gitignore. Please specify which of the two is the problem, and I will surely provide a fix.
The first, of course, I wouldn't complain otherwise :)
https://gerrit.wikimedia.org/r/#/c/104165/ appears to do the job.
Please see https://gerrit.wikimedia.org/r/#/c/104784
Change 104784 had a related patch set uploaded by TheDJ: Add .gitignore to the /skins directory https://gerrit.wikimedia.org/r/104784
Change 104784 merged by jenkins-bot: Add .gitignore to the /skins directory https://gerrit.wikimedia.org/r/104784
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Thanks for the reminder; somehow, closing this bug slipped through the cracks.
