Last modified: 2014-02-24 21:06:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57487, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55487 - Center GettingStarted modal in IE7
Center GettingStarted modal in IE7
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Low normal (vote)
: ---
Assigned To: Sam Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-08 23:45 UTC by Matthew Flaschen
Modified: 2014-02-24 21:06 UTC (History)
5 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot from IE7 on Sauce (138.41 KB, image/png)
2013-10-09 19:08 UTC, Steven Walling
Details

Description Matthew Flaschen 2013-10-08 23:45:15 UTC
It would be good to center the modal in at least IE7 (doesn't work in IE6 either, but I'm willing to drop that in this case).

Maybe we should just do it in JavaScript, with a resize listener.
Comment 1 Steven Walling 2013-10-09 19:08:08 UTC
Created attachment 13460 [details]
Screenshot from IE7 on Sauce
Comment 2 Matthew Flaschen 2014-02-06 07:37:19 UTC
(In reply to comment #0)
> Maybe we should just do it in JavaScript, with a resize listener.

This might also allow more flexible layouts, which is important now that we're rolling out to other language wikis (some of which have very different text length for their translations).

See http://tutorialzine.com/2010/03/centering-div-vertically-and-horizontally/
Comment 3 Matthew Flaschen 2014-02-06 07:43:14 UTC
There are also other CSS-only methods (e.g. http://benalman.com/code/test/css-centering.html which uses a bunch of nested divs) to investigate, but I haven't tested the cross-browser support yet.
Comment 4 Gerrit Notification Bot 2014-02-21 15:27:19 UTC
Change 114347 had a related patch set uploaded by Phuedx:
Center GettingStarted modal in IE7+

https://gerrit.wikimedia.org/r/114347
Comment 5 Sam Smith 2014-02-21 15:37:27 UTC
(In reply to Matthew Flaschen from comment #3)
> There are also other CSS-only methods (e.g.
> http://benalman.com/code/test/css-centering.html which uses a bunch of
> nested divs) to investigate, but I haven't tested the cross-browser support
> yet.

I've opted to introduce an additional div that encloses the modal so that it and the outer container can be styled with CSS tables, which gives you vertical centering. In IE6/7 you can fall back to push down/pull up by 50% of the modal's height to achieve the same effect.
Comment 6 Gerrit Notification Bot 2014-02-21 22:56:33 UTC
Change 114347 merged by jenkins-bot:
Center GettingStarted modal in IE7+

https://gerrit.wikimedia.org/r/114347

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links