Last modified: 2014-02-22 05:30:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57491, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55491 - "mention" notifications on Meta don't work for ns0
"mention" notifications on Meta don't work for ns0
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Kunal Mehta (Legoktm)
: easy
: 56919 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-09 00:50 UTC by MF-Warburg
Modified: 2014-02-22 05:30 UTC (History)
17 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MF-Warburg 2013-10-09 00:50:47 UTC
"mention" notifications (one's userpage being linked) on Meta don't work for the main namespace, which however hosts some important discussion and request pages there.
Comment 1 Kunal Mehta (Legoktm) 2013-10-09 00:56:18 UTC
The issue here is that it's hardcoded for talk namespaces and NS_PROJECT. We probably need some kind of configuration variable to modify it.

Echo/Hooks.php:455 			if ( $title->isTalkPage() || $title->inNamespace( NS_PROJECT ) ) {
Comment 2 PiRSquared17 2013-10-11 21:54:53 UTC
(In reply to comment #1)
> The issue here is that it's hardcoded for talk namespaces and NS_PROJECT. We
> probably need some kind of configuration variable to modify it.
> 
> Echo/Hooks.php:455             if ( $title->isTalkPage() ||
> $title->inNamespace( NS_PROJECT ) ) {

Is there any reason it needs to be restricted to certain namespaces at all?
Comment 3 spage 2013-10-17 17:15:40 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/326, but people from the community are welcome to contribute here and in Gerrit.
Comment 4 Gerrit Notification Bot 2013-11-04 17:58:50 UTC
Change 93508 had a related patch set uploaded by Gerrit Patch Uploader:
Remove namespace restriction for mention notifications

https://gerrit.wikimedia.org/r/93508
Comment 5 Kunal Mehta (Legoktm) 2013-11-12 00:27:03 UTC
*** Bug 56919 has been marked as a duplicate of this bug. ***
Comment 6 Spinningspark 2013-11-12 00:54:23 UTC
Just to note that there is a need for notifications in the template namespace as well.  Wikipedia DYK makes extensive use of this namespace for reviews.
Comment 7 Dereckson 2013-11-12 11:43:04 UTC
@Spinningspark the current patch address the notifications triggered by a signature.

Previous behavior: only on NS_PROJECT (Wikipedia:) and on every talk namespaces.
Patch behavior: everywhere

I offered in comments to make this configurable.

If the patch is merged as is, template namespace will be covered.
If my solution is used, the following configuration will be needed:

$wgEchoNotifications['baseNamespaces'] = array(
    default => array(
        NS_PROJECT
    ),

    metawiki => array(
        NS_PROJECT,
        NS_MAIN, //bug 55491
    ),

    enwiki => array(
        NS_PROJECT,
        NS_TEMPLATE, //bug 55491
    ),
);
Comment 8 Spinningspark 2013-11-12 12:25:30 UTC
I don't see any reason why it should be made configurable.  Why would we not want notifications from particular namespaces?  If my name were to be linked in article space I would certainly want to know about it top priority above everything else.  Perhaps that case could be implemented as a big orange bar at the top of the page (alright, perhaps not :) ).
Comment 9 MZMcBride 2013-11-12 13:20:54 UTC
(In reply to comment #8)
> I don't see any reason why it should be made configurable.  Why would we not
> want notifications from particular namespaces?

Edge cases, I imagine. But we should test it out and see what happens, in my opinion.
Comment 10 Spinningspark 2013-11-12 13:53:46 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > I don't see any reason why it should be made configurable.  Why would we not
> > want notifications from particular namespaces?
> 
> Edge cases, I imagine. But we should test it out and see what happens, in my
> opinion.

Edge cases are likely to be specific pages rather than entire namespaces.
Comment 11 MZMcBride 2013-11-12 13:55:36 UTC
(In reply to comment #10)
> Edge cases are likely to be specific pages rather than entire namespaces.

Sure, but... bug 50628. :-)
Comment 12 MF-Warburg 2014-01-04 23:15:20 UTC
What is hindering the approval of this patch? I see more and more that people are trying to ping each other on the main or project ns'es.
Comment 13 MZMcBride 2014-01-05 04:27:31 UTC
(In reply to comment #12)
> What is hindering the approval of this patch? I see more and more that people
> are trying to ping each other on the main or project ns'es.

https://gerrit.wikimedia.org/r/93508 needs to be updated and merged. I just bumped the changeset.
Comment 14 billinghurst 2014-02-13 22:21:34 UTC
shake shake shake shake shake. One month later since last shaking
Comment 15 MZMcBride 2014-02-14 06:32:45 UTC
Who's maintaining Echo?
Comment 16 Andre Klapper 2014-02-14 13:46:27 UTC
(In reply to MZMcBride from comment #15)
> Who's maintaining Echo?

See https://www.mediawiki.org/wiki/Developers/Maintainers (might be outdated); http://www.mediawiki.org/wiki/Extension:Echo ?
Comment 17 Gerrit Notification Bot 2014-02-22 05:07:08 UTC
Change 93508 merged by jenkins-bot:
Remove namespace restriction for mention notifications

https://gerrit.wikimedia.org/r/93508
Comment 18 Kunal Mehta (Legoktm) 2014-02-22 05:30:27 UTC
Will go out with 1.23wmf16.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links