Last modified: 2014-01-03 16:20:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57501, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55501 - the change made to fix Bug 46864 needs to be undone so that the banners would appear properly in Hebrew Wikivoyage
the change made to fix Bug 46864 needs to be undone so that the banners would...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Unprioritized normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-09 07:06 UTC by wikijunkiemail
Modified: 2014-01-03 16:20 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description wikijunkiemail 2013-10-09 07:06:57 UTC
There is now a consensus in the Hebrew Wikivoyage community to switch to the Panoramic banners which have an embedded TOC instead of the standard gray TOC (the same banners which are currently used in the English Wikivoyage). See discussion at https://he.wikivoyage.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%9E%D7%A1%D7%A2:%D7%A7%D7%A8%D7%95%D7%9F_%D7%94%D7%9E%D7%96%D7%A0%D7%95%D7%9F#.D7.91.D7.90.D7.A0.D7.A8.D7.99.D7.9D

Apparently the banners would only work properly for everyone by default if the change made to fix Bug 46864 (https://bugzilla.wikimedia.org/show_bug.cgi?id=46864) is undone.
Comment 1 Andre Klapper 2013-10-09 09:50:43 UTC
(In reply to comment #0)
> Apparently the banners would only work properly for everyone by default if
> the change made to fix Bug 46864
> (https://bugzilla.wikimedia.org/show_bug.cgi?id=46864) is undone.

Could you explain the "apparently"? :)

CC'ing Amir who was involved in bug 46864.
Comment 2 wikijunkiemail 2013-10-09 13:16:58 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > Apparently the banners would only work properly for everyone by default if
> > the change made to fix Bug 46864
> > (https://bugzilla.wikimedia.org/show_bug.cgi?id=46864) is undone.
> 
> Could you explain the "apparently"? :)
> 
> CC'ing Amir who was involved in bug 46864.

Currently the TOC of the panoramic banners appears with a gray background by default on the Hebrew Wikivoyage for anyone loading a page that uses it (this now happens by default both for the registered users and the non-registered users) which looks bad esthetically and is unreadable (white letters on light gray background). See example...

https://he.wikivoyage.org/wiki/%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:%D7%95%D7%99%D7%A7%D7%99%D7%92%27%D7%90%D7%A0%D7%A7%D7%99/%D7%98%D7%99%D7%95%D7%98%D7%94/%D7%95%D7%95%D7%A9%D7%99%D7%A0%D7%92%D7%98%D7%95%D7%9F_%D7%93%D7%99._%D7%A1%D7%99.

Nevertheless, when as a test I enable the "Floated table of contents" option in the preferences (in order to fix bug 46864 the floated TOC was disabled by default for all users), the TOC in the panoramic banner appears correctly as it appears in the English Wikivoyage.
Comment 3 Tomasz W. Kozlowski 2013-10-12 10:10:47 UTC
Reverting https://gerrit.wikimedia.org/r/#/c/61058/6/wmf-config/InitialiseSettings.php should make the trick.
Comment 4 Andre Klapper 2013-10-12 10:27:42 UTC
Hmm, hmm. This makes me wonder if I was wrong in closing bug 54648. :((
Comment 5 Tomasz W. Kozlowski 2013-10-21 18:41:05 UTC
Fixed by Reedy: https://gerrit.wikimedia.org/r/#/c/90935/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links