Last modified: 2013-10-15 09:04:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57517, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 55517 - Get rid of cli.php


Summary:	Get rid of cli.php

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Translate (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Siebrand Mazeland

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-10-09 14:13 UTC by Siebrand Mazeland
Modified:	2013-10-15 09:04 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2013-10-09 14:13:06 UTC

cli.php uses the non-standardly named legacy global $options. Because of this, we have to add code comments to not let CodeSniffer got mad over it.

function STDOUT( $str, $channel = null, $force = false ) {
	// @codingStandardsIgnoreStart Globals should have prefix "wg".
	global $options;
	// @codingStandardsIgnoreEnd

Code should be refactored to not use the legacy global $options.

Comment 1 Niklas Laxström 2013-10-09 14:14:43 UTC

The whole file is legacy, except perhaps language code parser.

Comment 2 Gerrit Notification Bot 2013-10-15 08:14:06 UTC

Change 89775 had a related patch set uploaded by Siebrand:
Get rid of cli.php

https://gerrit.wikimedia.org/r/89775

Comment 3 Siebrand Mazeland 2013-10-15 08:18:33 UTC

Following patches were needed to ensure this code is no longer used:
* https://gerrit.wikimedia.org/r/#/c/88957/
* https://gerrit.wikimedia.org/r/#/c/88961/
* https://gerrit.wikimedia.org/r/#/c/88982/
* https://gerrit.wikimedia.org/r/#/c/88985/
* https://gerrit.wikimedia.org/r/#/c/89033/
* https://gerrit.wikimedia.org/r/#/c/89114/
* https://gerrit.wikimedia.org/r/#/c/89344/

Comment 4 Gerrit Notification Bot 2013-10-15 09:04:31 UTC

Change 89775 merged by jenkins-bot:
Get rid of cli.php

https://gerrit.wikimedia.org/r/89775

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links