Last modified: 2014-10-16 11:52:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57536, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55536 - Give Bugzilla's "Save Changes" button some style.
Give Bugzilla's "Save Changes" button some style.
Status: NEW
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-09 23:09 UTC by Daniel Friesen
Modified: 2014-10-16 11:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Initial css (from mediawiki.ui.vector.css) (1.59 KB, text/plain)
2013-10-09 23:09 UTC, Daniel Friesen
Details
Button style without css (OSX + Firefox) (14.74 KB, image/png)
2013-10-09 23:11 UTC, Daniel Friesen
Details
Button style with modified mw.ui css (14.85 KB, image/png)
2013-10-09 23:12 UTC, Daniel Friesen
Details

Description Daniel Friesen 2013-10-09 23:09:08 UTC
Created attachment 13464 [details]
Initial css (from mediawiki.ui.vector.css)

The native "Save Changes" button in the corner here on Bugzilla looks horrible (at least on my Browser+OS combo). Lets try applying some style (how about the new mw.ui buttons being used in Vector).
Comment 1 Daniel Friesen 2013-10-09 23:11:46 UTC
Created attachment 13465 [details]
Button style without css (OSX + Firefox)
Comment 2 Daniel Friesen 2013-10-09 23:12:20 UTC
Created attachment 13466 [details]
Button style with modified mw.ui css
Comment 3 Andre Klapper 2013-10-10 00:08:15 UTC
If you would like to turn this into a Gerrit patch, the code is at https://git.wikimedia.org/tree/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/skins%2Fcontrib%2FWikimedia
Comment 4 Gerrit Notification Bot 2014-01-11 06:30:31 UTC
Change 106864 had a related patch set uploaded by 01tonythomas:
Gave Bugzilla's "Save Changes" button style.

https://gerrit.wikimedia.org/r/106864
Comment 5 Andre Klapper 2014-01-12 17:29:50 UTC
(Maybe my comment 3 towards the bug reporter was confusing for third parties, as it might have implied that I recommend and already support this change.)

So the proposed style can be seen e.g. for "Create another account" on https://en.wiktionary.org/w/index.php?title=Special:UserLogin&returnto=Wiktionary%3AMain+Page&type=signup but not for "Save" at the bottom of https://www.mediawiki.org/wiki/Special:Preferences?useskin=vector which is semantically close enough to Bugzilla's "Save Changes" button.

Hence I am not convinced why we should introduce such style inconsistency and make buttons look that much different from all other UI elements in our Bugzilla, but I welcome good arguments. :)

Technically: For approaches to make Bugzilla look more like MediaWiki's Vector skin, editing the CSS file /skins/contrib/Wikimedia/vector.css feels like a better fit.
Comment 6 Andre Klapper 2014-03-28 12:47:44 UTC
(In reply to Andre Klapper from comment #5)
> why should we introduce such style inconsistency and make buttons look
> that much different from all other UI elements in our Bugzilla?

Daniel: ping?
Comment 7 Daniel Friesen 2014-03-28 14:21:45 UTC
(In reply to Andre Klapper from comment #6)
> (In reply to Andre Klapper from comment #5)
> > why should we introduce such style inconsistency and make buttons look
> > that much different from all other UI elements in our Bugzilla?
> 
> Daniel: ping?

If that's an issue how about widening the scope of the bug? An interested party could try to restyle all the other form inputs to match those vector styles being created.
Comment 8 Andre Klapper 2014-04-01 21:58:48 UTC
Alright, however I wonder how to keep Bugzilla CSS and MediaWiki UI in sync in the long run...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links