Last modified: 2014-05-27 19:08:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57551, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55551 - VisualEditor: Use a hidden preference rather than cookie for logged-in users to remember hidebetawelcome
VisualEditor: Use a hidden preference rather than cookie for logged-in users ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Lowest enhancement
: VE-deploy-2014-05-15
Assigned To: James Forrester
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-10 08:20 UTC by Steven Walling
Modified: 2014-05-27 19:08 UTC (History)
11 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steven Walling 2013-10-10 08:20:21 UTC
The introductory dialog for VE is supposed to be seen only once per person. However, it seems that the way it is hidden for users is dependent on session information, probably a cookie? 

This means that every time I clear my cookies, open an incognito browser window, use a new browser, or use a new device, I get the intro again. Even if I'm using the same account. This stinks. 

In GuidedTours we solve this problem (not showing users repeated intro tours across devices/sessions) by setting a hidden preference when someone completes a tour. I'd like to suggest we do that for the VE intro, unless someone can think of a more elegant way to avoid this annoying behavior.
Comment 1 James Forrester 2014-01-27 10:23:18 UTC
Yay more preferences bloat (and a slower page load). :-(

Given that the welcome dialog is temporary, I was tempted to WONTFIX this, but if someone wants to code it up we might consider accepting it.
Comment 2 Steven Walling 2014-01-27 18:48:58 UTC
(In reply to comment #1)
> Yay more preferences bloat (and a slower page load). :-(
> 
> Given that the welcome dialog is temporary, I was tempted to WONTFIX this,
> but
> if someone wants to code it up we might consider accepting it.

In this case, the preference is hidden so while it might be bloat, it's not the kind that clogs up Special:Preferences. I'm not sure what's worse: presenting an unnecessary modal repeatedly or slowing page load time. Have we actually quantified how much each preference slows page load?
Comment 3 Gerrit Notification Bot 2014-04-14 23:40:57 UTC
Change 125914 had a related patch set uploaded by Jforrester:
Hide the beta welcome via a preference, not a cookie, for logged in users

https://gerrit.wikimedia.org/r/125914
Comment 4 Gerrit Notification Bot 2014-05-10 12:06:26 UTC
Change 125914 merged by jenkins-bot:
mw.ViewPageTarget: Hide the welcome dialog via a preference if possible

https://gerrit.wikimedia.org/r/125914
Comment 5 Tom Hart 2014-05-23 20:32:16 UTC
Where is this preference to turn of the Welcome overlay located? I am always getting the "Welcome..." dialog when I click Edit, while logged in on the same machine, same session... I'm using Chrome Version 35.0.1916.114 on Mavericks 10.9.2.
Comment 6 Alex Monk 2014-05-27 19:08:01 UTC
(In reply to Tom Hart from comment #5)
> Where is this preference to turn of the Welcome overlay located? I am always
> getting the "Welcome..." dialog when I click Edit, while logged in on the
> same machine, same session... I'm using Chrome Version 35.0.1916.114 on
> Mavericks 10.9.2.

It's hidden, only the server interacts with it. This is bug 65821

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links