Last modified: 2013-11-09 09:23:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57553, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55553 - mediawiki.inspect returns incorrect values in debug mode
mediawiki.inspect returns incorrect values in debug mode
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-10 09:07 UTC by Matthew Flaschen
Modified: 2013-11-09 09:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-10-10 09:07:13 UTC 
It does check if it's a real function/CSS info before adding to the total, but if it's not, it just returns 0.  It should verify that:

1. module.script is not an array (that means it's an array of URLs)
2. module.style.url is not set.

If either is, it should return null.
Comment 1 Gerrit Notification Bot 2013-10-11 10:50:56 UTC 
Change 89175 had a related patch set uploaded by Ori.livneh:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/89175
Comment 2 Gerrit Notification Bot 2013-10-11 17:27:47 UTC 
Change 89175 merged by jenkins-bot:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/89175
Comment 3 Gerrit Notification Bot 2013-10-22 21:50:37 UTC 
Change 91299 had a related patch set uploaded by Ori.livneh:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/91299
Comment 4 Gerrit Notification Bot 2013-10-22 21:59:21 UTC 
Change 91299 merged by jenkins-bot:
mw.inspect: decline to report module sizes when in debug mode

https://gerrit.wikimedia.org/r/91299
Comment 5 Umherirrender 2013-11-09 09:23:15 UTC 
(In reply to comment #4)
https://gerrit.wikimedia.org/r/91299

Was only a cherry pick, back to FIXED as of Ori at 2013-10-11 17:29:20 UTC
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links