Last modified: 2013-10-23 13:16:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57569, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55569 - Make the Claims list not depend on hashes
Make the Claims list not depend on hashes
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-10 16:45 UTC by Daniel Kinzler
Modified: 2013-10-23 13:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2013-10-10 16:45:48 UTC 
Claim hashes are not unique, so the Claims object should be oblivious to them. Claims should instead assure that Claim GUIDs are unique in the list.
Comment 1 Daniel Kinzler 2013-10-10 16:47:53 UTC 
Some more background: In particular, Claims::getDiff was using a hash based lookup that would result in invalid diffs and cause failed assertions in some cases.
Comment 2 Gerrit Notification Bot 2013-10-10 16:55:52 UTC 
Change 89015 had a related patch set uploaded by Daniel Kinzler:
(bug #55569) Make Claims list not use hashes.

https://gerrit.wikimedia.org/r/89015
Comment 3 Gerrit Notification Bot 2013-10-10 16:56:37 UTC 
Change 89016 had a related patch set uploaded by Daniel Kinzler:
(bug #55569) Fix tests after Claims no longer use hashes.

https://gerrit.wikimedia.org/r/89016
Comment 4 Gerrit Notification Bot 2013-10-12 02:23:14 UTC 
Change 89015 merged by Jeroen De Dauw:
(bug #55569) Make Claims list not use hashes.

https://gerrit.wikimedia.org/r/89015
Comment 5 Gerrit Notification Bot 2013-10-12 19:36:54 UTC 
Change 89016 merged by jenkins-bot:
(bug #55569) Fix tests after Claims no longer use hashes.

https://gerrit.wikimedia.org/r/89016
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links