Last modified: 2013-12-31 07:48:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57583, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55583 - Generate user config files at runtime, not install time
Generate user config files at runtime, not install time
Status: RESOLVED FIXED
Product: Pywikibot
Classification: Unclassified
General (Other open bugs)
core-(2.0)
All Linux
: High major
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-10 19:51 UTC by yardenack
Modified: 2013-12-31 07:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description yardenack 2013-10-10 19:51:14 UTC 
I'm packaging pywikibot for Arch Linux here: https://aur.archlinux.org/packages/python2-pywikibot-git/

Packing software for distribution means that install scripts might be run by a different person than the user. Install scripts are not the place for user config, and it's also bad practice to force ANY interactive configs at that stage.

Please don't run generate_user_files.py from setup.py. Find some way to do this at runtime.

Or, ideally, to behave sanely with no configs at all.

At the moment we are just providing a sample config for users to edit, and doing: sed -i /generate_user_files.py/Id setup.py
Comment 1 Kunal Mehta (Legoktm) 2013-10-10 21:02:55 UTC 
This also blocking packaging for pypi as well.
Comment 2 Gerrit Notification Bot 2013-12-15 16:26:06 UTC 
Change 101662 had a related patch set uploaded by Merlijn van Deen:
(bug 55583) Do not create user-config if stdin is not a tty

https://gerrit.wikimedia.org/r/101662
Comment 3 Merlijn van Deen (test) 2013-12-15 16:28:01 UTC 
yar, does this solve the issue on your end? Rewriting the user-config stuff to behave more sanely (which includes not requiring a user-config to begin with) is a longer-term project.
Comment 4 Gerrit Notification Bot 2013-12-15 16:41:44 UTC 
Change 101662 merged by jenkins-bot:
(bug 55583) Do not create user-config if stdin is not a tty

https://gerrit.wikimedia.org/r/101662
Comment 5 yardenack 2013-12-31 07:48:20 UTC 
This works, thanks!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links