Last modified: 2013-12-30 09:37:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57585, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55585 - Improve timeout handling on pages that take a long time to parse?
Improve timeout handling on pages that take a long time to parse?
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Arlo Breault
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-10 20:02 UTC by ssastry
Modified: 2013-12-30 09:37 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-10-10 20:02:31 UTC
Try fr/Liste_des_premiers_préfets_français_(1800-1815) locally. The output is different each time. The serialized (html2wt) output also has minor diffs. This seems like possible bugs in timeout handling. This page has a ton of template requests (some of which are responsible for closing tables) and timeouts in those can affect DOM. So, we need a way of dealing with the volume of requests to minimize timeout scenarios.
Comment 1 Gerrit Notification Bot 2013-10-24 02:26:59 UTC
Change 91554 had a related patch set uploaded by Arlolra:
Increase maxSockets for ApiRequests

https://gerrit.wikimedia.org/r/91554
Comment 2 Gerrit Notification Bot 2013-10-24 23:59:59 UTC
Change 91554 merged by jenkins-bot:
Generate less timeouts on pages that make a lot of API requests

https://gerrit.wikimedia.org/r/91554
Comment 3 Arlo Breault 2013-10-25 00:02:39 UTC
Subbu, let me know if those merged changes are enough to close this ticket.
Comment 4 ssastry 2013-10-25 15:08:33 UTC
Perhaps visit parsoid.wmflabs.org:8001 (our rt testing server), look at perf stats, sort by parse times and verify time changes on a few of the worst pages there. That link is currently unresponsive and the RT server might need a restart or something.
Comment 5 ssastry 2013-10-25 15:20:47 UTC
http://parsoid.wmflabs.org:8001/perfstats?orderby=time:parse is the direct url.
Comment 6 Arlo Breault 2013-10-25 18:09:02 UTC
ok, here are the four worst offenders on that list.


master

completed parsing of en:Russia_at_the_2004_Summer_Olympics in 33357 ms
completed parsing of ja:堺ブレイザーズの歴代選手・スタッフ一覧 in 17156 ms
completed parsing of it:Medagliati_olimpici_nell'atletica_leggera_-_Uomini in 21816 ms
completed parsing of it:Eccellenza_Lombardia_2011-2012 in 25213 ms


51d49eb7584a57c459d6409545e299ce61a3c34a (current commit of rt server) 

completed parsing of en:Russia_at_the_2004_Summer_Olympics in 106482 ms
completed parsing of ja:堺ブレイザーズの歴代選手・スタッフ一覧 in 66233 ms
completed parsing of it:Medagliati_olimpici_nell'atletica_leggera_-_Uomini in 150488 ms
completed parsing of it:Eccellenza_Lombardia_2011-2012 in 56719 ms
Comment 7 ssastry 2013-10-25 18:10:29 UTC
Awesome. I think we can now close this ticket :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links