Last modified: 2013-11-03 18:22:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57591, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55591 - drop obtrusive style rule for the <q> element
drop obtrusive style rule for the <q> element
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.22.0
All All
: Normal minor (vote)
: 1.23.0 release
Assigned To: entlinkt
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-10 21:00 UTC by entlinkt
Modified: 2013-11-03 18:22 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description entlinkt 2013-10-10 21:00:39 UTC
skins/common/commonElements.css currently contains a rather obtrusive style rule that messes up font rendering:

q {
	font-family: Times, "Times New Roman", serif;
	font-style: italic;
}

This is very old code that has been present long before <q> was allowed in wikitext. I suspect that it was added because IE <= 7 doesn't insert quotation marks around <q>, as it should. So the rule was put in to make quotes at least somehow recognizable.

I don't think this is still justified (IE >= 8 and all other browsers insert quotation marks properly). The rule should be dropped or at least a CSS hack should be used to hide it from modern browsers.
Comment 1 Gerrit Notification Bot 2013-10-11 10:37:49 UTC
Change 89174 had a related patch set uploaded by Bartosz Dziewoński:
Remove obtrusive styles for <q>

https://gerrit.wikimedia.org/r/89174
Comment 2 Gerrit Notification Bot 2013-11-03 17:50:17 UTC
Change 89174 merged by jenkins-bot:
Remove obtrusive styles for <q>

https://gerrit.wikimedia.org/r/89174

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links