Last modified: 2014-02-12 23:53:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57596, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 55596 - Thanks button not styled
Thanks button not styled
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-10 21:26 UTC by Jon
Modified: 2014-02-12 23:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-10-10 21:26:18 UTC 
Visit https://m.mediawiki.org/wiki/Special:MobileDiff/797556?debug=true 
the Thanks button is not correctly styled here.
Eek.
Can replicate on master.
Comment 1 Jon 2013-10-10 21:28:44 UTC 
In JavaScript console:
Exception thrown by mobile.notifications.overlay: Template not found: overlays/notifications
Comment 2 Jon 2013-10-10 21:34:05 UTC 
False alarm - no longer get that exception... but still not seeing the correct styling.

(On a side note mobilediff.less should make better use of the .vertical-gradient mixin and nesting e.g. use &:active etc.. )
Comment 3 Jon 2013-10-10 21:35:28 UTC 
The css expects a .content wrapper but that no longer exists.
Comment 4 Gerrit Notification Bot 2013-10-10 21:48:36 UTC 
Change 89122 had a related patch set uploaded by Kaldari:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/89122
Comment 5 Gerrit Notification Bot 2013-10-11 01:34:02 UTC 
Change 89122 merged by jenkins-bot:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/89122
Comment 6 Gerrit Notification Bot 2013-10-15 23:06:29 UTC 
Change 90053 had a related patch set uploaded by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90053
Comment 7 Gerrit Notification Bot 2013-10-15 23:07:18 UTC 
Change 90054 had a related patch set uploaded by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90054
Comment 8 Gerrit Notification Bot 2013-10-15 23:09:09 UTC 
Change 90053 merged by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90053
Comment 9 Gerrit Notification Bot 2013-10-15 23:09:26 UTC 
Change 90054 merged by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90054
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links