Last modified: 2014-01-02 23:45:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57597, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55597 - Flow events not showing up in my watchlist
Flow events not showing up in my watchlist
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-10 22:03 UTC by Maryana Pinchuk
Modified: 2014-01-02 23:45 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Maryana Pinchuk 2013-10-10 22:03:20 UTC
Observed on http://ee-flow.wmflabs.org/wiki/Special:Watchlist

I can see Flow events in recent changes just fine, but they don't show up in my watchlist, even though I'm watching Flow-enabled pages :(
Comment 1 Erik Bernhardson 2013-10-16 00:34:28 UTC
Looked through this one, it requires another core change to fix.  That change can be found in gerrit as 90051 . Its a fairly simple and unobtrusive fix.
Comment 2 Gerrit Notification Bot 2013-10-28 21:34:23 UTC
Change 92427 had a related patch set uploaded by EBernhardson:
Show flow events in watchlist

https://gerrit.wikimedia.org/r/92427
Comment 3 Gerrit Notification Bot 2013-10-31 21:45:30 UTC
Change 92427 merged by jenkins-bot:
Show flow events in watchlist

https://gerrit.wikimedia.org/r/92427
Comment 4 Maryana Pinchuk 2013-11-20 20:06:53 UTC
This still isn't working on ee-flow. Watch any Flow-enabled page; you won't see changes to it in your watchlist.
Comment 5 Maryana Pinchuk 2013-11-20 20:10:00 UTC
Probably related: Flow actions also don't show up in my contributions.
Comment 6 Gerrit Notification Bot 2013-11-20 20:16:56 UTC
Change 96578 had a related patch set uploaded by EBernhardson:
Hook expects old RC_* value for watchlist

https://gerrit.wikimedia.org/r/96578
Comment 7 Erik Bernhardson 2013-11-20 20:20:45 UTC
Special:Contributions is actually completely independant, it needs implementation of the ContribsPager::reallyDoQuery hook
Comment 8 Gerrit Notification Bot 2013-11-21 00:54:49 UTC
Change 96578 merged by jenkins-bot:
Hook expects old RC_* value for watchlist

https://gerrit.wikimedia.org/r/96578
Comment 9 Quiddity 2013-12-17 21:53:06 UTC
Re-opening - nothing from Flow Boards is showing in my https://www.mediawiki.org/wiki/Special:Watchlist
Comment 10 Erik Bernhardson 2013-12-24 18:40:59 UTC
seems to work on ee-flow but not on mediawiki.org, will have to investigate more.
Comment 11 Gerrit Notification Bot 2013-12-31 23:40:51 UTC
Change 104781 had a related patch set uploaded by EBernhardson:
Allow page_namespace IS NULL in watchlist query

https://gerrit.wikimedia.org/r/104781
Comment 12 Gerrit Notification Bot 2013-12-31 23:51:01 UTC
Change 104781 merged by jenkins-bot:
Allow page_namespace IS NULL in watchlist query

https://gerrit.wikimedia.org/r/104781
Comment 13 spage 2014-01-01 00:08:56 UTC
LiquidThreads adds a test to the watchlist query to exclude its Thread namespace:
    AND (page_namespace != '90')

But Flow changes don't have a namespace, so this is (NULL != '90') which in the hell of SQL evaluates to NULL not 1, so they were getting excluded too.

For posterity, a production Special:Watchlist query on a Wiki with Flow and LQT (but not Wikibase/Wikidata) looks like:

SELECT  rc_id,
        rc_timestamp,
        rc_user,
        rc_user_text,
        rc_namespace,
        rc_title,
        rc_comment,
        rc_minor,
        rc_bot,
        rc_new,
        rc_cur_id,
        rc_this_oldid,
        rc_last_oldid,
        rc_type,
        rc_source,
        rc_patrolled,
        rc_ip,
        rc_old_len,
        rc_new_len,
        rc_deleted,
        rc_logid,
        rc_log_type,
        rc_log_action,
        rc_params,
        wl_notificationtimestamp,
        (
          SELECT  GROUP_CONCAT(ct_tag SEPARATOR ',')
            FROM `change_tag`
            WHERE ct_rc_id=rc_id
        )
  AS ts_tags,fp_stable,fp_pending_since
  FROM `recentchanges`
        INNER JOIN `watchlist` ON (wl_user = '19998' AND (wl_namespace=rc_namespace) AND (wl_title=rc_title))
        LEFT JOIN `page` ON ((rc_cur_id=page_id))
        LEFT JOIN `flaggedpages` ON ((fp_page_id = rc_cur_id))
  WHERE (rc_timestamp > '20131228230259')
    AND ((rc_this_oldid=page_latest) OR rc_type IN ('3','142') )
    AND (page_namespace != '90')
  ORDER BY rc_timestamp DESC
Comment 14 spage 2014-01-02 23:45:27 UTC
Seems fixed in production in 1.23wmf9

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links