Last modified: 2014-07-18 19:05:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57604, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55604 - Disabling a role with a PHP INI file does not remove the file
Disabling a role with a PHP INI file does not remove the file
Status: RESOLVED FIXED
Product: MediaWiki-Vagrant
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Ori Livneh
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-11 05:55 UTC by Matthew Flaschen
Modified: 2014-07-18 19:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-10-11 05:55:33 UTC
Disabling a role with a PHP INI file (such as remote_debug), does not remove that file.
Comment 1 Bryan Davis 2014-07-10 17:02:07 UTC
Verified to still be a valid issue with fss role. Apache files placed with apache::mod_conf are likely to have the same problem. Both php::ini and apache::mod_conf support `ensure => absent` but do not automatically clean up files.

I'm not sure there is a better answer than "rebuild your VM after you remove roles if you need to ensure that all resources are cleaned up". This is in line with the "treat servers as cattle not pets" concept of virtualized computing.
Comment 2 Matthew Flaschen 2014-07-18 17:46:38 UTC
At the same time, though, this works for the files in settings.d/puppet-managed .  So it seems like it may be possible here too.
Comment 3 Bryan Davis 2014-07-18 17:50:48 UTC
settings.d/puppet-managed uses Puppet's recursive management functionality. This instructs puppet to remove any files in the directory or a sub directory that isn't explicitly managed by puppet during the current Puppet run.

If we were to do this with the php ini files we would need to manage all of the files explicitly in our puppet manifests.
Comment 4 Ori Livneh 2014-07-18 18:11:04 UTC
(In reply to Bryan Davis from comment #3)
> settings.d/puppet-managed uses Puppet's recursive management functionality.
> This instructs puppet to remove any files in the directory or a sub
> directory that isn't explicitly managed by puppet during the current Puppet
> run.
> 
> If we were to do this with the php ini files we would need to manage all of
> the files explicitly in our puppet manifests.

Not necessarily. Puppet File resources representing recursively-managed directories take an 'ignore' parameter that lets you specify a filename pattern which Puppet should not manage. If we give all Puppet-managed files some predictable filename pattern, we could tell Puppet to ignore everything that doesn't match that pattern.
Comment 5 Gerrit Notification Bot 2014-07-18 18:33:22 UTC
Change 147543 had a related patch set uploaded by Ori.livneh:
Manage /etc/php5/mods-available recursively

https://gerrit.wikimedia.org/r/147543
Comment 6 Gerrit Notification Bot 2014-07-18 19:04:25 UTC
Change 147543 merged by jenkins-bot:
Manage /etc/php5/mods-available recursively

https://gerrit.wikimedia.org/r/147543

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links